Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web): Introduce Item component #DS-1047 #1150

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Feat(web): Introduce Item component #DS-1047 #1150

merged 1 commit into from
Nov 30, 2023

Conversation

crishpeen
Copy link
Member

@crishpeen crishpeen commented Nov 15, 2023 •
edited
Loading

Description

Additional context

Issue reference

DS-1047

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 4d98af2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/655f82d37159b200087ec0c2

@github-actions github-actions bot added the feature New feature or request label Nov 15, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 4d98af2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/655f82d4d0526900086bf487
😎 Deploy Preview https://deploy-preview-1150--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 4d98af2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/655f82d3665e8b00083c85df
😎 Deploy Preview https://deploy-preview-1150--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 4d98af2
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/655f82d30e75fc0008690945

literat
literat approved these changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤷

adamkudrna
adamkudrna requested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! However I found a few things to clarify 🙂.

packages/web/src/scss/components/Item/_Item.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Item/_Item.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Item/_Item.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Item/_Item.scss Outdated Show resolved Hide resolved
packages/web/src/scss/components/Item/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/Item/_Item.scss Show resolved Hide resolved
packages/web/src/scss/components/Item/_Item.scss Show resolved Hide resolved
packages/web/src/scss/components/Item/index.html Outdated Show resolved Hide resolved
packages/web/src/scss/components/Item/README.md Show resolved Hide resolved
packages/web/src/scss/components/Item/README.md Outdated Show resolved Hide resolved
adamkudrna
adamkudrna approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! I only have doubts about the demo:

  • How to present the component width: narrow may be misleading, full-width is ugly.
  • To change labels by element type, or not to change.

But I don't have any constructive proposals.

@crishpeen
Copy link
Member Author

Good job! I only have doubts about the demo:

  • How to present the component width: narrow may be misleading, full-width is ugly.
  • To change labels by element type, or not to change.

But I don't have any constructive proposals.

I suggest we open this again when we embed this in the Dropdown component. Then we might figure out a better solution.

@crishpeen crishpeen changed the base branch from main to integration/item November 30, 2023 08:38
@crishpeen crishpeen merged commit 7bd2ae7 into integration/item Nov 30, 2023
23 checks passed
@crishpeen crishpeen deleted the feature/web-item branch November 30, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani left review comments

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

Assignees

@crishpeen crishpeen

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @literat @adamkudrna @pavelklibani