Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Twig scanner into Analytics #1147

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Conversation

literat
Copy link
Collaborator

@literat literat commented Nov 13, 2023

Description

Additional context

Testing build:
lmc-eu-spirit-analytics-v0.1.4-alpha.8.tgz

Inspired by:

Issue reference

https://jira.lmc.cz/browse/DS-874


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@github-actions github-actions bot added the feature New feature or request label Nov 13, 2023
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit a2ac755
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/656728e8ab8b60000832812e
😎 Deploy Preview https://deploy-preview-1147--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit a2ac755
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/656728e82b51f60008b98878
😎 Deploy Preview https://deploy-preview-1147--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit a2ac755
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/656728e811519900085a3d35

Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit a2ac755
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/656728e8b73b83000842ee58
😎 Deploy Preview https://deploy-preview-1147--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat force-pushed the feat/DS-874-analytics-twig-parser branch from ac2ecb9 to 14857db Compare November 20, 2023 19:39
@coveralls
Copy link

coveralls commented Nov 20, 2023

Coverage Status

coverage: 57.917% (-27.0%) from 84.868%
when pulling 683d124 on feat/DS-874-analytics-twig-parser
into 4ccaf16 on main.

@literat literat marked this pull request as ready for review November 21, 2023 10:46
@literat literat requested a review from a team as a code owner November 21, 2023 10:46
Copy link
Contributor

@pavelklibani pavelklibani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uf, seems ok 😅

@literat literat force-pushed the feat/DS-874-analytics-twig-parser branch from 683d124 to a2ac755 Compare November 29, 2023 12:04
@literat literat merged commit 0d6fd70 into main Nov 29, 2023
29 checks passed
@literat literat deleted the feat/DS-874-analytics-twig-parser branch November 29, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants