Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web-react): Polymorph Link component types #DS-1060 #1146

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Fix(web-react): Polymorph Link component types #DS-1060 #1146

merged 2 commits into from
Nov 15, 2023

Conversation

pavelklibani
Copy link
Contributor

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@pavelklibani pavelklibani self-assigned this Nov 13, 2023
@github-actions github-actions bot added the bug Something isn't working label Nov 13, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 539505f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65539368925ff90009c76d03
😎 Deploy Preview https://deploy-preview-1146--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 539505f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6553936889495b00086210f1

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 539505f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6553936846fba80008792dbf

@netlify Netlify
Copy link

netlify bot commented Nov 13, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 539505f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65539369d307d70008f62553
😎 Deploy Preview https://deploy-preview-1146--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani force-pushed the fix/DS-1060-polymorph-link branch from 1710e70 to f5a0e98 Compare November 14, 2023 12:15
@pavelklibani pavelklibani marked this pull request as ready for review November 14, 2023 12:15
@pavelklibani pavelklibani requested review from literat and a team as code owners November 14, 2023 12:15
literat
literat approved these changes Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pavelklibani
Fix(web-react): Polymorph Link component types #DS-1060
45100ab
@pavelklibani
Docs(web-react): Adding elementType to api table and new poly. example
539505f 
- There was missing prop elementType in API table
- Add new example "Custom polymorphic component"
@pavelklibani pavelklibani force-pushed the fix/DS-1060-polymorph-link branch from f5a0e98 to 539505f Compare November 14, 2023 15:33
@coveralls
Copy link

Coverage Status

coverage: 84.802% (-11.7%) from 96.46%
when pulling 539505f on fix/DS-1060-polymorph-link
into 81d9952 on main.

@pavelklibani pavelklibani merged commit e7d8cda into main Nov 15, 2023
19 checks passed
@pavelklibani pavelklibani deleted the fix/DS-1060-polymorph-link branch November 15, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat literat approved these changes

Assignees

@pavelklibani pavelklibani

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelklibani @coveralls @literat