Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web-react): Add useScrollControl hook and block scrolling when Dialog open #DS-1052 #1140

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix(web-react): Add useScrollControl hook and block scrolling when Dialog open #DS-1052 #1140

merged 1 commit into from
Nov 23, 2023

Conversation

crishpeen
Copy link
Member

Description

Additional context

Draft till next sprint.

Issue reference

DS-1052

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify Netlify
Copy link

netlify bot commented Nov 10, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit c842b7c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/655f0bec4aa3530008952760
😎 Deploy Preview https://deploy-preview-1140--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Nov 10, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 10, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit c842b7c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/655f0bec874fea000817ccbf

@netlify Netlify
Copy link

netlify bot commented Nov 10, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit c842b7c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/655f0bec4e273b0008df941d
😎 Deploy Preview https://deploy-preview-1140--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 10, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit c842b7c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/655f0bec0b815d0008ced62b
😎 Deploy Preview https://deploy-preview-1140--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen marked this pull request as ready for review November 14, 2023 13:12
@crishpeen crishpeen requested review from literat, pavelklibani and a team as code owners November 14, 2023 13:12
literat
literat approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen crishpeen force-pushed the fix/dialog-block-scroll branch from 73840df to c842b7c Compare November 23, 2023 08:23
@coveralls
Copy link

coveralls commented Nov 23, 2023 •
edited
Loading

Coverage Status

coverage: 85.026% (+0.2%) from 84.868%
when pulling c842b7c on fix/dialog-block-scroll
into f700adf on main.

@crishpeen crishpeen merged commit 37cae9e into main Nov 23, 2023
29 checks passed
@crishpeen crishpeen deleted the fix/dialog-block-scroll branch November 23, 2023 08:37
@literat literat mentioned this pull request Jan 4, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@literat literat literat approved these changes

Assignees

@crishpeen crishpeen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @coveralls @literat @pavelklibani