Feat: Allow object in Grid prop cols, deprecate desktop and tablet #DS-995 #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani and
a team
as code owners
pavelklibani
approved these changes
Nov 14, 2023
literat
reviewed
Nov 15, 2023
crishpeen
force-pushed
the
feature/grid-cols
branch
from
b9d12e7 to
ccadde5
Compare
adamkudrna
approved these changes
Nov 28, 2023
packages/web-twig/src/Resources/components/Grid/__tests__/__fixtures__/gridDefault.twig
Outdated
Show resolved
Hide resolved
crishpeen
force-pushed
the
feature/grid-cols
branch
from
ccadde5 to
24bbc6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deprecated desktop and tablet props.
Allow object inside cols prop.
Used the new cols prop object everywhere (hopefully).
Two small docs/test fixes.
Additional context
Draft till next sprint.
Issue reference
DS-995
Before submitting the PR, please make sure you do the following
fixes #123).