-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(icons): Do not remove colors from icons with -colored
suffix #DS-990
#1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
adamkudrna and
a team
as code owners
November 9, 2023 13:42
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 115a48f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for spirit-design-system-react canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
pavelklibani
approved these changes
Nov 9, 2023
literat
reviewed
Nov 9, 2023
adamkudrna
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docs 👍🏻.
literat
reviewed
Nov 9, 2023
literat
approved these changes
Nov 9, 2023
crishpeen
force-pushed
the
feature/colored-icons
branch
from
November 10, 2023 16:44
115a48f
to
42d2f3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference
DS-990
Before submitting the PR, please make sure you do the following
fixes #123
).