Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(icons): Do not remove colors from icons with -colored suffix #DS-990 #1134

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

DS-990


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@crishpeen crishpeen requested review from literat, adamkudrna and a team as code owners November 9, 2023 13:42
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 42d2f3d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/654e5df84fec3600086210b2

@github-actions github-actions bot added the feature New feature or request label Nov 9, 2023
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 42d2f3d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/654e5df8d50b01000887722c

Copy link

nx-cloud bot commented Nov 9, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 115a48f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 42d2f3d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/654e5df8d13c3500082e17d2

@coveralls
Copy link

coveralls commented Nov 9, 2023

Coverage Status

coverage: 79.885% (-16.6%) from 96.46%
when pulling 115a48f on feature/colored-icons
into eb16312 on main.

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 42d2f3d
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/654e5df88db65b000845e03f

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs 👍🏻.

packages/icons/scripts/buildSvg.js Outdated Show resolved Hide resolved
@crishpeen crishpeen force-pushed the feature/colored-icons branch from 115a48f to 42d2f3d Compare November 10, 2023 16:44
@crishpeen crishpeen merged commit 5da46d2 into main Nov 14, 2023
31 checks passed
@crishpeen crishpeen deleted the feature/colored-icons branch November 14, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants