Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web-react): Corrected the example for Dropdown #DS-601 #1131

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Nov 6, 2023

Description

  • Replaced renderToggle with renderTrigger as the correct prop

Additional context

Reported bug was fixed by previous changes and bug reporter confirmed that it is working.
I just found this typo in README file.

Issue reference

web-react: Dropdown nejde zavřít s a elementem jak trigger

- Replaced `renderToggle` with `renderTrigger` as the correct prop
@pavelklibani pavelklibani self-assigned this Nov 6, 2023
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 15c2b51
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/654920cab375ad0008db1ffc

@github-actions github-actions bot added the bug Something isn't working label Nov 6, 2023
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 15c2b51
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/654920cae2be480008bd5af8
😎 Deploy Preview https://deploy-preview-1131--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 15c2b51
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/654920ca9195ea0008053abe

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 15c2b51
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/654920ca5ec07e000803aadd
😎 Deploy Preview https://deploy-preview-1131--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Nov 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 15c2b51. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@coveralls
Copy link

Coverage Status

coverage: 84.896%. remained the same
when pulling 15c2b51 on fix/DS-601-dropdown-trigger
into 3c0f08b on main.

@pavelklibani pavelklibani marked this pull request as ready for review November 7, 2023 09:36
@pavelklibani pavelklibani requested review from literat and a team as code owners November 7, 2023 09:36
@pavelklibani pavelklibani added the documentation Improvements or additions to documentation label Nov 7, 2023
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@pavelklibani pavelklibani merged commit ddd7e20 into main Nov 7, 2023
20 checks passed
@pavelklibani pavelklibani deleted the fix/DS-601-dropdown-trigger branch November 7, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants