web-react: Avoid using useLayoutEffect hook on the server side
#1129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f548848. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
reviewed
Nov 6, 2023
packages/web-react/src/components/FileUploader/useFileUploaderAttachment.ts
Outdated
Show resolved
Hide resolved
* avoid using `useLayoutEffect` hook on server side * @see https://gist.github.com/gaearon/e7d97cdf38a2907924ea12e4ebdf3c85 * @see https://usehooks-ts.com/react-hook/use-isomorphic-layout-effect * @see https://medium.com/@alexandereardon/uselayouteffect-and-ssr-192986cdcf7a
* to avoid error messages while rendering on the server side
literat
force-pushed
the
fix/DS-1004-use-isomorphic-layout-effect
branch
from
5fe5531 to
f548848
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useLayoutEffectdoes not work on the server side, so we must useuseEffectinstead.However we can use both by wrapping them to new
useIsomorphicLayoutEffecthook which detects the browser environment.Additional context
Issue reference
https://jira.lmc.cz/browse/DS-1004
Before submitting the PR, please make sure you do the following
fixes #123).