Fix(web-react): Icon component supports SSR #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
reviewed
Nov 6, 2023
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7a7c08b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
pavelklibani
approved these changes
Nov 7, 2023
literat
force-pushed
the
fix/web-react-ssr-icon
branch
2 times, most recently
from
13b458e to
df5ebf0
Compare
* `dangerouslySetInnerHtml` do not work while rendering on server
* this `Warning: Prop `dangerouslySetInnerHTML` did not match.` error
was raised
* we can avoid this by wrapping the component with something like
`<NoSsr>`
* @see: https://stackoverflow.com/questions/64079321/react-tooltip-and-next-js-ssr-issue
* or by using some library like ReactHtmlParser to render HTML string
magically as a component
* @see: https://www.npmjs.com/package/react-html-parser
literat
force-pushed
the
fix/web-react-ssr-icon
branch
from
df5ebf0 to
7a7c08b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
dangerouslySetInnerHtmldoes not work while rendering on the serverWarning: PropdangerouslySetInnerHTMLdid not match.error was raised<NoSsr>Additional context
https://www.npmjs.com/package/react-html-parser
https://github.com/peternewnham/react-html-parser
https://stackoverflow.com/questions/39758136/how-to-render-html-string-as-real-html
https://stackoverflow.com/questions/64079321/react-tooltip-and-next-js-ssr-issue
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123).