Allow combining links and buttons in HeaderDesktopActions
#1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7266be9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
✅ Deploy Preview for spirit-design-system-react canceled.
|
adamkudrna
commented
Nov 2, 2023
...ges/web-twig/src/Resources/components/Header/stories/HeaderInvertedWithActionsAndDialog.twig
Outdated
Show resolved
Hide resolved
adamkudrna
commented
Nov 2, 2023
adamkudrna
commented
Nov 2, 2023
pavelklibani
approved these changes
Nov 3, 2023
crishpeen
approved these changes
Nov 6, 2023
...ges/web-twig/src/Resources/components/Header/stories/HeaderInvertedWithActionsAndDialog.twig
Outdated
Show resolved
Hide resolved
adamkudrna
force-pushed
the
feature/header-allow-custom-content-in-nav-item
branch
2 times, most recently
from
44ce5d8 to
fdb4144
Compare
…wig implementation
adamkudrna
force-pushed
the
feature/header-allow-custom-content-in-nav-item
branch
from
fdb4144 to
7266be9
Compare
adamkudrna
changed the title
HeaderNavItemHeaderDesktopActions
adamkudrna
deleted the
feature/header-allow-custom-content-in-nav-item
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are both
HeaderNavItemcomponents:Previously, the content of
HeaderNavItemwas always stretched over its height:https://jira.lmc.cz/browse/DS-1044