Fix(web-react): Recalculate FileUploader image preview by crop values #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literat
requested review from
pavelklibani,
a team,
adamkudrna and
crishpeen
as code owners
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 27a3a13. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
pavelklibani
approved these changes
Nov 2, 2023
adamkudrna
reviewed
Nov 2, 2023
packages/web-react/src/components/FileUploader/useFileUploaderStyleProps.ts
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/FileUploader/useFileUploaderStyleProps.ts
Outdated
Show resolved
Hide resolved
literat
force-pushed
the
fix/DS-1038-fileuploader-meta-crop
branch
from
fa702ca to
fb17044
Compare
adamkudrna
reviewed
Nov 2, 2023
packages/web-react/src/components/FileUploader/__tests__/useFileUploaderStyleProps.test.ts
Show resolved
Hide resolved
packages/web-react/src/components/FileUploader/useFileUploaderStyleProps.ts
Outdated
Show resolved
Hide resolved
* need to use additional dimensions - natural width and height to
calculate dimensions of previewed image
* also need to better calculate the scale of the entire image and also
position when we need to display the possible crop
refs #DS-1038
* need to use additional dimensions - natural width and height to
calculate dimensions of previewed image
* also need to better calculate the scale of the entire image and also
position when we need to display the possible crop
refs #DS-1038
* allow larger base64 image to increase quality of previewed image refs #DS-1039
* allow larger base64 image to increase quality of previewed image refs #DS-1039
literat
force-pushed
the
fix/DS-1038-fileuploader-meta-crop
branch
from
fb17044 to
27a3a13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
calculate dimensions of previewed image
position when we need to display the possible crop
Additional context
https://almamedia.slack.com/archives/C050YPZ3YRW/p1698830929192449
Issue reference
https://jira.lmc.cz/browse/DS-1038
Before submitting the PR, please make sure you do the following
fixes #123).