Docs(web): Showcase placement valuse on Tooltip demo #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literat
requested review from
adamkudrna,
crishpeen,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
documentation
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
commented
Oct 30, 2023
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit fb98553. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
Use this also in the twig and react package. |
literat
force-pushed
the
docs/web-showcase-placement-on-tooltip
branch
from
0004056 to
2125d71
Compare
literat
force-pushed
the
docs/web-showcase-placement-on-tooltip
branch
from
bcf9348 to
aae6a89
Compare
|
Modifications were done also in web-react and web-twig packages. @adamkudrna, please, recheck this. I have moved all your changes to other technologies. |
pavelklibani
reviewed
Nov 3, 2023
packages/web-react/src/components/Tooltip/demo/TooltipOnHover.tsx
Outdated
Show resolved
Hide resolved
packages/web-react/src/components/Tooltip/demo/TooltipPlacements.tsx
Outdated
Show resolved
Hide resolved
packages/web-twig/src/Resources/components/Tooltip/stories/TooltipOnHover.twig
Outdated
Show resolved
Hide resolved
packages/web-twig/src/Resources/components/Tooltip/stories/TooltipPlacements.twig
Outdated
Show resolved
Hide resolved
literat
force-pushed
the
docs/web-showcase-placement-on-tooltip
branch
2 times, most recently
from
ac0116a to
75d3e35
Compare
pavelklibani
reviewed
Nov 7, 2023
packages/web-twig/src/Resources/components/Tooltip/stories/TooltipPlacements.twig
Outdated
Show resolved
Hide resolved
pavelklibani
approved these changes
Nov 7, 2023
literat
force-pushed
the
docs/web-showcase-placement-on-tooltip
branch
from
dc5e576 to
ca5340e
Compare
adamkudrna
approved these changes
Nov 9, 2023
…ble in more viewport sizes
… usable in more viewport sizes
…e usable in more viewport sizes
literat
force-pushed
the
docs/web-showcase-placement-on-tooltip
branch
from
7043506 to
fb98553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have tried to showcase the values of the placement dictionary the same way as the Floating UI does on its webpage.
Additional context
Issue reference
https://jira.lmc.cz/browse/DS-923
Before submitting the PR, please make sure you do the following
fixes #123).