-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(web-twig): Do not render input props when set to false
#1117
Conversation
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
30dba34
to
54b6850
Compare
✅ Deploy Preview for spirit-design-system-validations canceled.
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 54b6850. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
✅ Deploy Preview for spirit-design-system-react canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, we're dealing with the same problem in the ModalDialog
and novalidate
prop. That prop is applied via mainProps()
, but I'm afraid we're not able to apply the same condition there because some attributes may required false
value. 🙈
...web-twig/src/Resources/components/FileUploader/__tests__/__fixtures__/fileUploaderInput.twig
Outdated
Show resolved
Hide resolved
...web-twig/src/Resources/components/FileUploader/__tests__/__fixtures__/fileUploaderInput.twig
Outdated
Show resolved
Hide resolved
...web-twig/src/Resources/components/FileUploader/__tests__/__fixtures__/fileUploaderInput.twig
Outdated
Show resolved
Hide resolved
I will check all those places and rewrite the documentation thus it is a native attribute and must be treated that way. |
54b6850
to
0f8d6cb
Compare
@dlouhak @adamkudrna Please, give this a second try. I have unified the usage of space between braces and also tried to better describe the usage of "void" attributes in our docs. |
e11041f
to
f731f7e
Compare
Description
The input attribute will render even if there are set to
false
. This should solve the problem, but I do not know if it affects anything else. The tests are ok. But you know.Additional context
Issue reference
https://almamedia.slack.com/archives/C0502FGLG3G/p1698159019944579
Before submitting the PR, please make sure you do the following
fixes #123
).