Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(web-react): Remove Storybook addon meant for migration #1102

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

literat
Copy link
Collaborator

@literat literat commented Oct 22, 2023

Description

  • remove @storybook/addon-mdx-gfm that was remaining form migration process

Additional context

https://storybook.js.org/addons/@storybook/addon-mdx-gfm

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested a review from a team as a code owner October 22, 2023 19:21
@netlify
Copy link

netlify bot commented Oct 22, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 4e671af
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65365889d739600008b0e9d9

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 22, 2023
@netlify
Copy link

netlify bot commented Oct 22, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 4e671af
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6536588adfec000008dd27d7

@netlify
Copy link

netlify bot commented Oct 22, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 4e671af
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6536588ae5ca9500085e1733

@netlify
Copy link

netlify bot commented Oct 22, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 4e671af
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6536588a11bb0b0008836ac7

@nx-cloud
Copy link

nx-cloud bot commented Oct 22, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4e671af. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@github-actions
Copy link
Contributor

Coverage Status

coverage: 69.754% (-26.7%) from 96.46% when pulling 5bae716 on docs/remove-storybook-plugin into 0cb30d5 on main.

  * remove `@storybook/addon-mdx-gfm` that was remaining form migration
    process
@literat literat force-pushed the docs/remove-storybook-plugin branch from 5bae716 to 4e671af Compare October 23, 2023 11:27
@literat literat merged commit e55af7c into main Oct 23, 2023
17 checks passed
@literat literat deleted the docs/remove-storybook-plugin branch October 23, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant