Fix(web-twig): Fix pass custom classnames to the Spinner component
#1099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlouhak
requested review from
literat,
adamkudrna,
crishpeen,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-react canceled.
|
dlouhak
commented
Oct 19, 2023
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit de57f0f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
|
No description provided? Can you please explain how this happened so we can prevent it in the future? |
crishpeen
approved these changes
Oct 19, 2023
packages/web-twig/src/Resources/components/Spinner/Spinner.twig
Outdated
Show resolved
Hide resolved
dlouhak
force-pushed
the
bugfix/spinner-classnames
branch
from
2e93659 to
de57f0f
Compare
Git blame will answer your questions. 🙃 |
literat
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.