Feat(web-twig): Use the new Placement dictionary in Dropdown and Tooltip #DS-923
#1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react canceled.
|
adamkudrna
changed the title
Dropdown and `T…Dropdown and Tooltip #DS-923
|
LGTM, I have written all my questions and suggestions for the first issue. |
crishpeen
approved these changes
Oct 16, 2023
adamkudrna
force-pushed
the
feature/web-placement-dictionary
branch
from
37f9b5f to
1382252
Compare
adamkudrna
force-pushed
the
feature/twig-placement-dictionary
branch
from
8b40926 to
740f1a3
Compare
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 740f1a3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DropdownandTooltipAdditional context
Issue reference
https://jira.lmc.cz/browse/DS-923