-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(web): Introduce Placement dictionary and use it in Dropdown
and Tooltip
#DS-923
#1092
Conversation
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
I have written a few suggestions, but nothing blocking. It is looking good. Thanks a lot for your effort, it looks like a really complicated task. 👏 |
I have a question about generating the placements. It is necessary to have placement for each component generated? What about to make it like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤕
That could be a next level of abstraction. We already abstract things like But the idea seems very interesting to me. It's a Tailwind-like tear-down: find what's common, abstract, reuse. Something between design tokens and components. cc @crishpeen |
…d `Tooltip` #DS-923
37f9b5f
to
1382252
Compare
Description
Dropdown
andTooltip
componentsAdditional context
Issue reference
https://jira.lmc.cz/browse/DS-923