Feat: Make BreadcrumbsItem href optional #DS-957 #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
adamkudrna,
pavelklibani and
a team
as code owners
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
force-pushed
the
feat/DS-835-breadcrumbs-item
branch
from
9588755 to
565cf41
Compare
|
I have made a few changes to BreadcrumbsItem PR, so let's rebase this first. |
literat
reviewed
Oct 10, 2023
literat
force-pushed
the
feat/DS-835-breadcrumbs-item
branch
3 times, most recently
from
6d851bb to
e14e100
Compare
crishpeen
force-pushed
the
feat/DS-957-breadcrumbs-item-non-interactive
branch
from
da9868f to
06d7703
Compare
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
literat
reviewed
Oct 16, 2023
packages/web-react/src/components/Breadcrumbs/__tests__/BreadcrumbsItem.test.tsx
Outdated
Show resolved
Hide resolved
literat
reviewed
Oct 16, 2023
packages/web-react/src/components/Breadcrumbs/demo/BreadcrumbsCurrentNotLink.tsx
Outdated
Show resolved
Hide resolved
literat
reviewed
Oct 16, 2023
packages/web-react/src/components/Breadcrumbs/BreadcrumbsItem.tsx
Outdated
Show resolved
Hide resolved
literat
force-pushed
the
feat/DS-957-breadcrumbs-item-non-interactive
branch
from
06d7703 to
1acd016
Compare
literat
approved these changes
Oct 17, 2023
literat
force-pushed
the
feat/DS-957-breadcrumbs-item-non-interactive
branch
2 times, most recently
from
c62a26d to
79c0451
Compare
crishpeen
commented
Oct 17, 2023
crishpeen
commented
Oct 17, 2023
packages/web-twig/src/Resources/components/Breadcrumbs/Breadcrumbs.stories.twig
Outdated
Show resolved
Hide resolved
packages/web-twig/src/Resources/components/Breadcrumbs/README.md
Outdated
Show resolved
Hide resolved
literat
force-pushed
the
feat/DS-957-breadcrumbs-item-non-interactive
branch
from
79c0451 to
db0dfd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference
DS-957
Before submitting the PR, please make sure you do the following
fixes #123).