Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(web-twig): Use embed in DocsSection to fix falling tests with unclosed block #1089

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

crishpeen
Copy link
Member

@crishpeen crishpeen commented Oct 10, 2023

Description

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 91c6675
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/65251934323e460007c57541

@github-actions github-actions bot added the bug Something isn't working label Oct 10, 2023
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 91c6675
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/65251934c8058a0007ba0636

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 91c6675
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/652519343ba10e0009337785

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 91c6675
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/652519343479820008e55e61

@coveralls
Copy link

coveralls commented Oct 10, 2023

Coverage Status

coverage: 70.949%. remained the same when pulling 91c6675 on fix/docs-section-content into 2094a04 on main.

@literat
Copy link
Collaborator

literat commented Oct 10, 2023

Thanks for fixing that 👏

@crishpeen crishpeen merged commit 96f3c2e into main Oct 17, 2023
30 checks passed
@crishpeen crishpeen deleted the fix/docs-section-content branch October 17, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants