Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a shared Placement dictionary for Dropdown and Tooltip #1078

Closed
wants to merge 5 commits into from
Closed

Use a shared Placement dictionary for Dropdown and Tooltip #1078

wants to merge 5 commits into from

Conversation

adamkudrna
Copy link
Contributor

No description provided.

@adamkudrna adamkudrna self-assigned this Oct 3, 2023
@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit f8a1c7f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/652573dc9847800008e5925e
😎 Deploy Preview https://deploy-preview-1078--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit f8a1c7f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/652573dc48e1ad0008b1d831

@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit f8a1c7f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/652573dc2d1ecf00075e9a1b

@github-actions github-actions bot added the feature New feature or request label Oct 3, 2023
@netlify
Copy link

netlify bot commented Oct 3, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit f8a1c7f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/652573dc108afe0008015784

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Coverage Status

coverage: 69.502% (-2.3%) from 71.782% when pulling 9c87105 on feature/dropdown-placement into cdc8913 on main.

@adamkudrna adamkudrna force-pushed the feature/dropdown-placement branch from 9c87105 to 3eeeb4b Compare October 10, 2023 15:04
@coveralls
Copy link

coveralls commented Oct 10, 2023 •
edited
Loading

Coverage Status

coverage: 96.46% (+25.5%) from 70.949% when pulling f8a1c7f on feature/dropdown-placement into 2094a04 on main.

@adamkudrna adamkudrna closed this Oct 10, 2023
@literat literat deleted the feature/dropdown-placement branch March 4, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat Awaiting requested review from literat literat will be requested when the pull request is marked ready for review literat is a code owner

@crishpeen crishpeen Awaiting requested review from crishpeen crishpeen will be requested when the pull request is marked ready for review crishpeen is a code owner

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani will be requested when the pull request is marked ready for review pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj will be requested when the pull request is marked ready for review curdaj is a code owner

Assignees

@adamkudrna adamkudrna

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamkudrna @coveralls