Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(exporter-scss): Fix exporter to make it work again after Supernov… #1076

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix(exporter-scss): Fix exporter to make it work again after Supernov… #1076

merged 1 commit into from
Oct 3, 2023

Conversation

crishpeen
Copy link
Member

…a token changes #DS-936

Changes:

  • Split Radius tokens to separate file
  • Remove font weight normalization as it is not needed anymore
  • Add temporary hack to make font style italic based on name, until Supernova makes it clear how to do it in JS
  • Fix token grouping

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@crishpeen crishpeen requested a review from a team as a code owner September 28, 2023 13:02
@netlify
Copy link

netlify bot commented Sep 28, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit f1a9642
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/651c02c64525c600080131c2

@netlify
Copy link

netlify bot commented Sep 28, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit f1a9642
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/651c02c68883680008363a1c

@netlify
Copy link

netlify bot commented Sep 28, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit f1a9642
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/651c02c6e7edc20008fc2555

@github-actions github-actions bot added the bug Something isn't working label Sep 28, 2023
@netlify
Copy link

netlify bot commented Sep 28, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit f1a9642
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/651c02c66feae40008ae3944

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Coverage Status

coverage: 69.502% (-2.3%) from 71.782% when pulling 657a8d4 on fix/scss-exporter-tokens-update into cdc8913 on main.

literat
literat approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crishpeen
Fix(exporter-scss): Fix exporter to make it work again after Supernov…
f1a9642 
…a token changes #DS-936

Changes:
- Split Radius tokens to separate file
- Remove font weight normalization as it is not needed anymore
- Add temporary hack to make font style italic based on name, until
Supernova makes it clear how to do it in JS
- Fix token grouping
@crishpeen crishpeen force-pushed the fix/scss-exporter-tokens-update branch from 657a8d4 to f1a9642 Compare October 3, 2023 12:02
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Coverage Status

coverage: 69.502% (-2.3%) from 71.782% when pulling f1a9642 on fix/scss-exporter-tokens-update into cdc8913 on main.

@crishpeen crishpeen merged commit 05865fd into main Oct 3, 2023
16 checks passed
@crishpeen crishpeen deleted the fix/scss-exporter-tokens-update branch October 3, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna left review comments

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@crishpeen crishpeen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crishpeen @literat @adamkudrna @pavelklibani