Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(web, web-twig, web-react): Component demos #1075

Merged
merged 6 commits into from
Oct 4, 2023
Merged

Docs(web, web-twig, web-react): Component demos #1075

merged 6 commits into from
Oct 4, 2023

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Sep 25, 2023 •
edited
Loading

Description

Last touches to web, web-twig and web-react demos.
Mosty fixed spacing problems and adding new 'docs-Stack' structure.

Button & ButtonLink

  • <ButtonLink /> separated from <Button /> component in react
    • But <ButtonLink /> is still exported from <Button /> for backward compatibility
    • <ButtonLink /> will be removed in the future in favor of <Button />.

Issue reference

Demos: last touches

@pavelklibani pavelklibani self-assigned this Sep 25, 2023
@netlify
Copy link

netlify bot commented Sep 25, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit edb41fd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/651c1a4fbd9ea8000730aa46
😎 Deploy Preview https://deploy-preview-1075--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 25, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit edb41fd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/651c1a4f19900d0008d90db4
😎 Deploy Preview https://deploy-preview-1075--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 25, 2023
@netlify
Copy link

netlify bot commented Sep 25, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit edb41fd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/651c1a4fc45df90008048f62

@netlify
Copy link

netlify bot commented Sep 25, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit edb41fd
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/651c1a4f0fb07400087cadfa
😎 Deploy Preview https://deploy-preview-1075--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Sep 25, 2023 •
edited
Loading

Coverage Status

coverage: 70.562% (+1.1%) from 69.502% when pulling edb41fd on docs/DS-979-all-demos into 05865fd on main.

@pavelklibani pavelklibani force-pushed the docs/DS-979-all-demos branch 3 times, most recently from 00f7fdf to ebd50dd Compare September 26, 2023 09:33
@pavelklibani pavelklibani marked this pull request as ready for review September 26, 2023 09:33
literat
literat approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but few suggestions for better commits:

Docs(web-react): Alert demo #DS-979 - What is the change -> Docs(web-react): Unify Alert demo cross packages #DS-979 is better, IMHO

Docs(web-twig): Minor fixes in twig demos #DS-979 -> Docs(web-twig): Unified Alert copies #DS-979

Docs(web): Web demos 'docs' structure #DS-979 -> Docs(web): Unify component examples in demos #DS-979 ? I am not quite sure, but you are repeating web and docs

[Docs(web-react): ButtonLink component #DS-979d -> [Docs(web-react): Separate ButtonLink component #DS-979d

@literat
Copy link
Collaborator

literat commented Sep 27, 2023

LGTM but few suggestions for better commits:

Docs(web-react): Alert demo #DS-979 - What is the change -> Docs(web-react): Unify Alert demo cross packages #DS-979 is better, IMHO

Docs(web-twig): Minor fixes in twig demos #DS-979 -> Docs(web-twig): Unified Alert copies #DS-979

Docs(web): Web demos 'docs' structure #DS-979 -> Docs(web): Unify component examples in demos #DS-979 ? I am not quite sure, but you are repeating web and docs

[Docs(web-react): ButtonLink component #DS-979d -> [Docs(web-react): Separate ButtonLink component #DS-979d

@pavelklibani Please, feel free to make any modifications but I was missing some information in the commit headline.

crishpeen
crishpeen reviewed Oct 3, 2023
View reviewed changes
packages/web-react/src/components/Alert/demo/AlertCentered.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/Alert/demo/AlertIcons.tsx Show resolved Hide resolved
packages/web-react/src/components/ButtonLink/README.md Outdated Show resolved Hide resolved
packages/web-react/src/components/ButtonLink/demo/ButtonLinkDefault.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/ButtonLink/demo/ButtonLinkDemoFactory.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/ButtonLink/demo/ButtonLinkDefault.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/ButtonLink/demo/ButtonLinkDemoFactory.tsx Outdated Show resolved Hide resolved
packages/web-react/src/components/ButtonLink/stories/ButtonLink.stories.tsx Outdated Show resolved Hide resolved
packages/web/src/scss/components/Collapse/index.html Outdated Show resolved Hide resolved
@pavelklibani
Docs(web): Unify component examples in demos #DS-979
a49f675 
- Added missing 'docs' structure for web demos so we have same
structure in all demos across packages
@pavelklibani
Docs(web-twig): Unified Alert copies #DS-979
9a0fd8f 
- Minor text changes to twig demos so all demos across all packages are
  consistent
@pavelklibani
Docs(web-react): Unify Alert demo cross packages #DS-979
17cdb4c 
- Alert demo is now same in all packages
@pavelklibani
Docs(web-react): FieldGroup demo separated to more files
4036206 
- FiledGroup is now separated to more files like other demos
@pavelklibani
Docs(web-react): Multiple demos tweak to mach other technologies #DS-979
43a7878 
- Small tweaks to Checkbox, Collapse, Container, Grid, Header,
Pagination and Select demos to match other technologies.
@pavelklibani
Docs(web-react): Separate ButtonLink component #DS-979
edb41fd 
- ButtonLink component is now a separate component
- Moved ButtonLink files from Button to ButtonLink folder
@pavelklibani pavelklibani force-pushed the docs/DS-979-all-demos branch from d10f3eb to edb41fd Compare October 3, 2023 13:42
@pavelklibani pavelklibani merged commit 7a39ef6 into main Oct 4, 2023
30 checks passed
@pavelklibani pavelklibani deleted the docs/DS-979-all-demos branch October 4, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen left review comments

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

Assignees

@pavelklibani pavelklibani

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelklibani @coveralls @literat @crishpeen