Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some code styl problem on Button components #1074

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Conversation

literat
Copy link
Collaborator

@literat literat commented Sep 22, 2023

Description

While investigating problems with types and polymorphism of Button and ButtonLink components I have fixed some ESlint issues.

Additional context

  • reordering of imports
  • restructuring of props

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@literat literat requested review from pavelklibani and a team as code owners September 22, 2023 12:01
@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit db32ed1
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/650d8222b8d83400089abc37

@github-actions github-actions bot added the bug Something isn't working label Sep 22, 2023
@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit db32ed1
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/650d8222a7c40b00084c96d0

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit db32ed1
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/650d8222bc0646000871340a
😎 Deploy Preview https://deploy-preview-1074--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 22, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit db32ed1
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/650d8222657f2700088237b1
😎 Deploy Preview https://deploy-preview-1074--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

Coverage Status

coverage: 69.502% (-27.0%) from 96.46% when pulling db32ed1 on fix/button-link-type into 3dd7c3b on main.

@literat literat merged commit ea75846 into main Sep 26, 2023
19 checks passed
@literat literat deleted the fix/button-link-type branch September 26, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants