Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(web-twig): Ignore tests and stories from exported package #1073

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

literat
Copy link
Collaborator

@literat literat commented Sep 20, 2023

Description

Fixing configuration of the web-twig-bundle package which includes tests and stories and this should not happen.

Additional context

Thanks @janicekt for this notice.

You can reproduce the package archive by running git archive --format=tar.gz -o web-twig-test.tar.gz HEAD in packages/web-twig.

Issue reference

https://jira.lmc.cz/browse/DS-969


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 5a59921
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/650b15cc88768c00085b0a49

@literat literat requested a review from janicekt September 20, 2023 15:54
@github-actions github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Sep 20, 2023
@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 5a59921
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/650b15cc19d39400087cf503

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 5a59921
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/650b15cc8a321a00085d064e

@netlify
Copy link

netlify bot commented Sep 20, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 5a59921
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/650b15ccb0d6a10008d2f36d

@coveralls
Copy link

coveralls commented Sep 20, 2023

Coverage Status

coverage: 70.887%. remained the same when pulling 5a59921 on chore/web-twig-ignore-tests-export into b63bf9e on main.

@literat literat merged commit 7205145 into main Sep 21, 2023
29 checks passed
@literat literat deleted the chore/web-twig-ignore-tests-export branch September 21, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Changes to the build process or auxilary tools and libraries or other maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants