Refactor/demo package #1072
Merged
Refactor/demo package #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
github-actions
bot
added
the
refactoring
literat
commented
Sep 18, 2023
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
literat
requested review from
adamkudrna,
crishpeen,
pavelklibani and
a team
as code owners
pavelklibani
approved these changes
Sep 19, 2023
adamkudrna
approved these changes
Sep 19, 2023
literat
force-pushed
the
refactor/demo-package
branch
from
9124b21 to
b2547ff
Compare
adamkudrna
approved these changes
Sep 19, 2023
* with CSS file that is same and copied over other packages
literat
force-pushed
the
refactor/demo-package
branch
from
b2547ff to
b24f5a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unify multiple demo.css files into one package that is used by other demo-related apps.
Additional context
Currently, most of the changes done by @pavelklibani in his PRs are broken due to visual changes and non-unified CSS across all demos. This should solve the problem.
Issue reference
No issue reference here.
Before submitting the PR, please make sure you do the following
fixes #123).