Docs(web-react, web-twig, web): Add Tooltip demo #DS-914 #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
documentation
pavelklibani
changed the title
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Changes unknown when pulling 998c252 on docs/DS-914-tooltip-demo into ** on main**. |
|
Should we keep |
Yes, please. |
pavelklibani
force-pushed
the
docs/DS-914-tooltip-demo
branch
2 times, most recently
from
4a6ade3 to
5761326
Compare
pavelklibani
requested review from
literat,
adamkudrna,
crishpeen and
a team
as code owners
crishpeen
approved these changes
Sep 21, 2023
packages/web-react/src/components/Tooltip/demo/TooltipFloatingUi.tsx
Outdated
Show resolved
Hide resolved
packages/web-twig/src/Resources/components/Tooltip/stories/TooltipFloatingUI.twig
Outdated
Show resolved
Hide resolved
packages/web-twig/src/Resources/components/Tooltip/stories/TooltipDismissibleViaJS.twig
Outdated
Show resolved
Hide resolved
- Tooltip demo in web-react is now same as demo in web and web-twig
- Tooltip demo in web-twig is now same as demo in web and web-react
- Tooltip demo in web is now same as demo in web-twig and web-react
pavelklibani
force-pushed
the
docs/DS-914-tooltip-demo
branch
from
198092e to
998c252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Fixed bug in web & web-twig FloatingUi demo (data-placement => data-spirit-placement)
Updated version of FloatingUI from 0.5.4 to 1.5.3 in .mjs file
(packages/web/src/scss/components/Tooltip/floating-ui-example.mjs)
Issue reference
Demo: Tooltip má ve všech technologiích stejná dema