Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web-react, web): Add TextField demo #DS-913 #1070

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

pavelklibani
Copy link
Contributor

Description

TextField demos are now same in all packages

Issue reference

Demo: TextField má ve všech technologiích stejná dema

@pavelklibani pavelklibani self-assigned this Sep 17, 2023
@netlify
Copy link

netlify bot commented Sep 17, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 2fed992
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6509b3a49240190007b0126f
😎 Deploy Preview https://deploy-preview-1070--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 17, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 2fed992
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6509b3a4947f650007acb81d

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 17, 2023
@pavelklibani pavelklibani force-pushed the docs/DS-912-textfield-demo branch from 4a7038a to 15d223b Compare September 17, 2023 00:46
@netlify
Copy link

netlify bot commented Sep 17, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 2fed992
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6509b3a488d4b50008c36b7c
😎 Deploy Preview https://deploy-preview-1070--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 17, 2023

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 2fed992
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6509b3a45a8cd40008e8bf84
😎 Deploy Preview https://deploy-preview-1070--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

Coverage Status

coverage: 69.502% (-27.0%) from 96.46% when pulling 15d223b on docs/DS-912-textfield-demo into 4e1b5eb on main.

@literat
Copy link
Collaborator

literat commented Sep 18, 2023

Screenshot 2023-09-18 at 9 37 50
Screenshot 2023-09-18 at 9 37 56
Screenshot 2023-09-18 at 9 38 18
Screenshot 2023-09-18 at 9 38 35

There are some visual inconsistencies that must be solved. Maybe @crishpeen or @adamkudrna could help.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some visual changes that break the layout.

- TextField demo in web-react is now same as demo in web and web-twig
- TextField demo in web is now same as demo in web-react and web-twig
@pavelklibani pavelklibani force-pushed the docs/DS-912-textfield-demo branch from 15d223b to 2fed992 Compare September 19, 2023 14:43
@coveralls
Copy link

coveralls commented Sep 19, 2023

Coverage Status

coverage: 70.951% (-25.5%) from 96.46% when pulling 2fed992 on docs/DS-912-textfield-demo into f126dca on main.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@pavelklibani pavelklibani merged commit a34e914 into main Sep 21, 2023
@pavelklibani pavelklibani deleted the docs/DS-912-textfield-demo branch September 21, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants