-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs(web-react, web): Add Stack demo #DS-908 #1066
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
a team,
adamkudrna and
crishpeen
as code owners
September 16, 2023 20:44
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 16, 2023
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
✅ Deploy Preview for spirit-design-system-demo canceled.
|
pavelklibani
force-pushed
the
docs/DS-908-stack-demo
branch
from
September 18, 2023 08:11
df7bd71
to
64f5b44
Compare
literat
reviewed
Sep 18, 2023
packages/web-react/src/components/Stack/demo/StackBlocksWithInnerDividersAndVerticalSpacing.tsx
Show resolved
Hide resolved
literat
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
- Stack demo in web-react is now same as demo in web and web-twig
- Stack demo in web is now same as demo in web-react and web-twig
pavelklibani
force-pushed
the
docs/DS-908-stack-demo
branch
from
September 19, 2023 13:54
64f5b44
to
defd3b5
Compare
crishpeen
approved these changes
Sep 21, 2023
packages/web-react/src/components/Stack/demo/StackBlocksWithInnerDividersAndVerticalSpacing.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tag demos are now same in all packages
Issue reference
Demo: Stack má ve všech technologiích stejná dema