Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web-react, web): Add Spinner demo #DS-907 #1062

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

pavelklibani
Copy link
Contributor

Description

Spinner demos are now same in all packages

Issue reference

Demo: Spinner má ve všech technologiích stejná dema

@pavelklibani pavelklibani self-assigned this Sep 16, 2023
@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit b3f6ed7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/650bfb1a44da9d0008fc17ea

@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit b3f6ed7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/650bfb1a20f4410008d06a33
😎 Deploy Preview https://deploy-preview-1062--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 16, 2023
@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit b3f6ed7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/650bfb1aa36f090008125bf6
😎 Deploy Preview https://deploy-preview-1062--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 16, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit b3f6ed7
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/650bfb1a57fe030008290446

@github-actions
Copy link
Contributor

Coverage Status

coverage: 69.502% (-27.0%) from 96.46% when pulling 6c70746 on docs/DS-907-spinner-demo into 4e1b5eb on main.

@pavelklibani pavelklibani force-pushed the docs/DS-907-spinner-demo branch from 6c70746 to f7a780c Compare September 18, 2023 08:08
@github-actions
Copy link
Contributor

Coverage Status

coverage: 69.502% (-27.0%) from 96.46% when pulling f7a780c on docs/DS-907-spinner-demo into 4e1b5eb on main.

@literat
Copy link
Collaborator

literat commented Sep 18, 2023

I think here is the same problem with missing docs-Stack.

@pavelklibani pavelklibani force-pushed the docs/DS-907-spinner-demo branch from f7a780c to e4c2a0a Compare September 19, 2023 13:46
@coveralls
Copy link

coveralls commented Sep 19, 2023

Coverage Status

coverage: 70.951% (+0.06%) from 70.887% when pulling b3f6ed7 on docs/DS-907-spinner-demo into 74e7fa8 on main.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

- Spinner demo in web-react is now same as demo in web and web-twig
- Spinner demo in web is now same as demo in web-react and web-twig
@pavelklibani pavelklibani force-pushed the docs/DS-907-spinner-demo branch from e4c2a0a to b3f6ed7 Compare September 21, 2023 08:13
@pavelklibani pavelklibani merged commit 4860146 into main Sep 21, 2023
18 checks passed
@pavelklibani pavelklibani deleted the docs/DS-907-spinner-demo branch September 21, 2023 11:03
@pavelklibani pavelklibani added run-visual-tests Runs visual regression testing on this PR and removed run-visual-tests Runs visual regression testing on this PR labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants