-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs(web-react, web): Add Spinner demo #DS-907 #1062
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelklibani
requested review from
literat,
a team,
adamkudrna and
crishpeen
as code owners
September 16, 2023 18:44
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Sep 16, 2023
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-demo canceled.
|
pavelklibani
force-pushed
the
docs/DS-907-spinner-demo
branch
from
September 18, 2023 08:08
6c70746
to
f7a780c
Compare
I think here is the same problem with missing |
pavelklibani
force-pushed
the
docs/DS-907-spinner-demo
branch
from
September 19, 2023 13:46
f7a780c
to
e4c2a0a
Compare
literat
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
crishpeen
approved these changes
Sep 21, 2023
- Spinner demo in web-react is now same as demo in web and web-twig
- Spinner demo in web is now same as demo in web-react and web-twig
pavelklibani
force-pushed
the
docs/DS-907-spinner-demo
branch
from
September 21, 2023 08:13
e4c2a0a
to
b3f6ed7
Compare
pavelklibani
added
run-visual-tests
Runs visual regression testing on this PR
and removed
run-visual-tests
Runs visual regression testing on this PR
labels
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spinner demos are now same in all packages
Issue reference
Demo: Spinner má ve všech technologiích stejná dema