Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(web-react): Introduce ModalCloseButton component #1058

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Refactor(web-react): Introduce ModalCloseButton component #1058

merged 1 commit into from
Sep 27, 2023

Conversation

literat
Copy link
Collaborator

@literat literat commented Sep 15, 2023

Description

This contribution has been, somehow, lost.

Additional context

Issue reference

#1046

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Sep 15, 2023
@netlify
Copy link

netlify bot commented Sep 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit b358724
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/651431702183a200081f890f
😎 Deploy Preview https://deploy-preview-1058--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit b358724
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/651431707491a300086e52f6
😎 Deploy Preview https://deploy-preview-1058--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat marked this pull request as ready for review September 15, 2023 12:19
@literat literat requested review from pavelklibani and a team as code owners September 15, 2023 12:19
@netlify
Copy link

netlify bot commented Sep 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit b358724
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/65143170c9e6220008a70607

@netlify
Copy link

netlify bot commented Sep 15, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit b358724
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/65143170456dc80008b75e81

@github-actions
Copy link
Contributor

Coverage Status

coverage: 69.502% (-27.0%) from 96.46% when pulling fb0248c on refactor/modal-close-button into 4e1b5eb on main.

@literat literat force-pushed the refactor/modal-close-button branch 2 times, most recently from a2dddf6 to fc89c16 Compare September 22, 2023 12:46
@literat literat requested a review from crishpeen September 22, 2023 12:46
@github-actions
Copy link
Contributor

Coverage Status

coverage: 69.502% (-27.0%) from 96.46% when pulling fc89c16 on refactor/modal-close-button into 3dd7c3b on main.

pavelklibani
pavelklibani reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@pavelklibani pavelklibani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be this component also exported in the index?

@literat literat force-pushed the refactor/modal-close-button branch from c92c93f to b358724 Compare September 27, 2023 13:43
@literat
Copy link
Collaborator Author

literat commented Sep 27, 2023

Shouldn't be this component also exported in the index?

I have added the export. Thanks.

@coveralls
Copy link

coveralls commented Sep 27, 2023 •
edited
Loading

Coverage Status

coverage: 70.762% (-25.7%) from 96.46% when pulling b358724 on refactor/modal-close-button into de5f9b2 on main.

@literat literat merged commit cdc8913 into main Sep 27, 2023
24 checks passed
@literat literat deleted the refactor/modal-close-button branch September 27, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelklibani pavelklibani pavelklibani approved these changes

@crishpeen crishpeen crishpeen approved these changes

Assignees

@literat literat

Labels
refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@literat @coveralls @crishpeen @pavelklibani