Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web, web-react, web-twig): Unify Modal READMEs #1056

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

adamkudrna
Copy link
Contributor

@adamkudrna adamkudrna commented Sep 14, 2023

I suppose there still may be some inconsistencies, please let me know if you find anything!

Issue reference

https://jira.lmc.cz/browse/DS-876

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 14, 2023
@coveralls
Copy link

coveralls commented Sep 14, 2023

Coverage Status

coverage: 70.919% (-25.5%) from 96.46% when pulling 3a7e93b on docs/unify-modal-readme into b16595c on main.

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 3a7e93b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6509a1aae4fd69000842a040
😎 Deploy Preview https://deploy-preview-1056--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 3a7e93b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6509a1aae6580d00081782de
😎 Deploy Preview https://deploy-preview-1056--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 3a7e93b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6509a1aa7e787a0008e24c09

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 3a7e93b
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6509a1aa9733b0000882775f
😎 Deploy Preview https://deploy-preview-1056--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@literat literat force-pushed the docs/unify-modal-readme branch from 7618182 to a8e5808 Compare September 14, 2023 12:35
@literat
Copy link
Collaborator

literat commented Sep 14, 2023

Find a few more things using Grammarly and fix them. Thanks for unifying the documentation. Michal checked this and it is ok 👍

@adamkudrna adamkudrna force-pushed the docs/unify-modal-readme branch from a8e5808 to 3a7e93b Compare September 19, 2023 13:27
@adamkudrna adamkudrna merged commit f126dca into main Sep 19, 2023
30 checks passed
@adamkudrna adamkudrna deleted the docs/unify-modal-readme branch September 19, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants