Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs(web-react): Add Icons demo #DS-900 #1054

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Docs(web-react): Add Icons demo #DS-900 #1054

merged 3 commits into from
Sep 21, 2023

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Sep 13, 2023 •
edited
Loading

Description

  • Add Components and Icons tabs in web-react app
  • Create demo page for icons in web-react
  • All layouts for icons tab are same in all apps

Additional context

Issue reference

Demo: Icon má ve všech technologiích stejná dema

@pavelklibani pavelklibani self-assigned this Sep 13, 2023
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 13, 2023
@netlify
Copy link

netlify bot commented Sep 13, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 2d9742f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6502feeb324d5c000878e21b

@netlify
Copy link

netlify bot commented Sep 13, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit 2d9742f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6502feeb70c16d0008810aba

@netlify
Copy link

netlify bot commented Sep 13, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 2d9742f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6502feebdad3d1000884fed4

@netlify
Copy link

netlify bot commented Sep 13, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit 2d9742f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6502feeb143ab9000820e626

@coveralls
Copy link

coveralls commented Sep 13, 2023 •
edited
Loading

Coverage Status

coverage: 70.278% (-26.2%) from 96.46% when pulling 2d9742f on docs/DS-900-icon-demo into 4e1b5eb on main.

@pavelklibani
Docs(web-react): Add Icons demo #DS-900
f45df2b 
- Add Components and Icons tabs
- Create demo page for icons
@pavelklibani
Docs(web): Add Icons demo #DS-900
d235e8d 
- Icons layout synced with other packages
@pavelklibani
Docs(web-twig): Add Icons demo #DS-900
2d9742f 
- Icons layout synced with other packages
@pavelklibani pavelklibani marked this pull request as ready for review September 14, 2023 12:43
literat
literat approved these changes Sep 14, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pavelklibani pavelklibani merged commit cce1910 into main Sep 21, 2023
32 checks passed
@pavelklibani pavelklibani deleted the docs/DS-900-icon-demo branch September 21, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crishpeen crishpeen crishpeen approved these changes

@literat literat literat approved these changes

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna is a code owner

Assignees

@pavelklibani pavelklibani

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pavelklibani @coveralls @literat @crishpeen