-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/ds 926 prefixes of utilities and helpers #1051
Refactor/ds 926 prefixes of utilities and helpers #1051
Conversation
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-react canceled.
|
Please see Breadcrumbs and FileUploaderInput too |
packages/web-twig/src/Resources/components/FileUploader/FileUploaderAttachment.twig
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still a few places to fix:
- Twig
FileUploaderInput
– link classes - Twig
Breadcrumbs
– display classes - Twig
FileUploader
– text-truncate
I hope the list is complete and correct 🙂
packages/web-twig/src/Resources/components/FileUploader/FileUploaderAttachment.twig
Show resolved
Hide resolved
packages/web-twig/src/Resources/components/FileUploader/FileUploaderAttachment.twig
Outdated
Show resolved
Hide resolved
Thanks. I did not notice. Fixed.
I think this should be a part of the new
I am unable to find another occurrence of
Thanks for your suggestions. I hope these are all occurrences we know about. |
27b7f8d
to
2c42cec
Compare
Well, I tried to do it right now. But it seems that it would be much bigger then I expected. So for now I have prefixed those classes and started to prepare the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
packages/web-twig/src/Resources/components/Breadcrumbs/Breadcrumbs.twig
Outdated
Show resolved
Hide resolved
packages/web-twig/src/Resources/components/FileUploader/FileUploaderInput.twig
Outdated
Show resolved
Hide resolved
52e9c9d
to
7d3c532
Compare
7d3c532
to
a070c5f
Compare
Description
Additional context
Issue reference
https://jira.lmc.cz/browse/DS-926
Before submitting the PR, please make sure you do the following
fixes #123
).