Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/ds 926 prefixes of utilities and helpers #1051

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

literat
Copy link
Collaborator

@literat literat commented Sep 11, 2023

Description

Additional context

Issue reference

https://jira.lmc.cz/browse/DS-926


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit a070c5f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6502f2cebfa69b0009e0fd74

@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Sep 11, 2023
@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit a070c5f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6502f2cecefe510008546703

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit a070c5f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6502f2ce25971800083d364a
😎 Deploy Preview https://deploy-preview-1051--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit a070c5f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6502f2ce32a1dc0008b5ca2c

@coveralls
Copy link

coveralls commented Sep 11, 2023

Coverage Status

coverage: 71.51% (-25.0%) from 96.46% when pulling a070c5f on refactor/DS-926-prefixes-of-utilities-and-helpers into a52215d on main.

@crishpeen
Copy link
Member

Please see Breadcrumbs and FileUploaderInput too

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few places to fix:

  • Twig FileUploaderInput – link classes
  • Twig Breadcrumbs – display classes
  • Twig FileUploader – text-truncate

I hope the list is complete and correct 🙂

@literat
Copy link
Collaborator Author

literat commented Sep 12, 2023

@adamkudrna

There are still a few places to fix:

  • Twig FileUploaderInput – link classes

Thanks. I did not notice. Fixed.

  • Twig Breadcrumbs – display classes

I think this should be a part of the new BreadcrumbItem, see https://jira.lmc.cz/browse/DS-835. Or do you think that we should fix this now?

  • Twig FileUploader – text-truncate

I am unable to find another occurrence of text-truncate. In FileUploader.twig there is no such class.

I hope the list is complete and correct 🙂

Thanks for your suggestions. I hope these are all occurrences we know about.

@literat literat force-pushed the refactor/DS-926-prefixes-of-utilities-and-helpers branch 2 times, most recently from 27b7f8d to 2c42cec Compare September 13, 2023 07:18
@literat
Copy link
Collaborator Author

literat commented Sep 13, 2023

I think this should be a part of the new BreadcrumbItem, see https://jira.lmc.cz/browse/DS-835. Or do you think that we should fix this now?

Well, I tried to do it right now. But it seems that it would be much bigger then I expected. So for now I have prefixed those classes and started to prepare the BreadcrumbsItem here #1052.

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@literat literat force-pushed the refactor/DS-926-prefixes-of-utilities-and-helpers branch from 52e9c9d to 7d3c532 Compare September 14, 2023 11:34
@literat literat force-pushed the refactor/DS-926-prefixes-of-utilities-and-helpers branch from 7d3c532 to a070c5f Compare September 14, 2023 11:47
@literat literat merged commit 4e1b5eb into main Sep 14, 2023
32 checks passed
@literat literat deleted the refactor/DS-926-prefixes-of-utilities-and-helpers branch September 14, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants