Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/ds 869 visual tests playwright #1050

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

literat
Copy link
Collaborator

@literat literat commented Sep 11, 2023

Description

Introducing visual regression testing using Playwright.

Additional context

Issue reference

https://jira.lmc.cz/browse/DS-869


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit aac5c42
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/651c0f1e831e550008dac998

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit aac5c42
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/651c0f1e848fa00008f5b9b6
😎 Deploy Preview https://deploy-preview-1050--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit aac5c42
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/651c0f1e888368000838c225
😎 Deploy Preview https://deploy-preview-1050--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 11, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit aac5c42
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/651c0f1eb113940008e6b84e

@github-actions
Copy link
Contributor

Coverage Status

coverage: 69.502% (-0.9%) from 70.438% when pulling b07e7c8 on test/DS-869-visual-tests-playwright into 8b0255f on main.

@literat literat force-pushed the test/DS-869-visual-tests-playwright branch from b07e7c8 to 65a6be6 Compare September 25, 2023 06:40
@coveralls
Copy link

coveralls commented Sep 25, 2023

Coverage Status

coverage: 67.646% (-1.9%) from 69.502% when pulling aac5c42 on test/DS-869-visual-tests-playwright into 05865fd on main.

@literat literat marked this pull request as ready for review September 25, 2023 10:39
@literat literat requested a review from a team as a code owner September 25, 2023 10:39
Copy link
Contributor

@pavelklibani pavelklibani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 👍

@literat literat force-pushed the test/DS-869-visual-tests-playwright branch from d96983b to c396e35 Compare October 3, 2023 12:47
CONTRIBUTING.md Outdated Show resolved Hide resolved
@literat literat force-pushed the test/DS-869-visual-tests-playwright branch from c396e35 to aac5c42 Compare October 3, 2023 12:54
@literat literat merged commit c4a5d72 into main Oct 4, 2023
17 checks passed
@literat literat deleted the test/DS-869-visual-tests-playwright branch October 4, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants