-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/use visually hidden component #1045
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literat
requested review from
adamkudrna,
crishpeen,
pavelklibani and
a team
as code owners
September 7, 2023 11:40
✅ Deploy Preview for spirit-design-system-demo canceled.
|
github-actions
bot
added
the
refactoring
A code change that neither fixes a bug nor adds a feature
label
Sep 7, 2023
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react canceled.
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
approved these changes
Sep 7, 2023
literat
force-pushed
the
refactor/use-visually-hidden-component
branch
from
September 7, 2023 15:54
afa762b
to
3cb3f69
Compare
pavelklibani
approved these changes
Sep 8, 2023
literat
force-pushed
the
refactor/use-visually-hidden-component
branch
from
September 8, 2023 13:47
5891229
to
33fe6a7
Compare
literat
force-pushed
the
refactor/use-visually-hidden-component
branch
from
September 8, 2023 13:47
33fe6a7
to
5ffdecb
Compare
literat
force-pushed
the
refactor/use-visually-hidden-component
branch
from
September 8, 2023 13:52
5ffdecb
to
d19b59e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using
VisuallyHidden
component instead of theaccessibility-hidden
class name.Additional context
Issue reference
Before submitting the PR, please make sure you do the following
fixes #123
).