Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/use visually hidden component #1045

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

literat
Copy link
Collaborator

@literat literat commented Sep 7, 2023

Description

Using VisuallyHidden component instead of the accessibility-hidden class name.

Additional context

Issue reference


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit d19b59e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/64fb2732a80493000851338d

@github-actions github-actions bot added the refactoring A code change that neither fixes a bug nor adds a feature label Sep 7, 2023
@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit d19b59e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/64fb2732bb55de0008c8f2bd

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for spirit-design-system-react canceled.

Name Link
🔨 Latest commit d19b59e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/64fb2732de863200084c5a95

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit d19b59e
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/64fb2732dd56400008d93bfa
😎 Deploy Preview https://deploy-preview-1045--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@literat literat force-pushed the refactor/use-visually-hidden-component branch from afa762b to 3cb3f69 Compare September 7, 2023 15:54
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Coverage Status

coverage: 69.502% (-27.0%) from 96.46% when pulling 3cb3f69 on refactor/use-visually-hidden-component into 32425d1 on main.

@literat literat force-pushed the refactor/use-visually-hidden-component branch from 5891229 to 33fe6a7 Compare September 8, 2023 13:47
@literat literat force-pushed the refactor/use-visually-hidden-component branch from 33fe6a7 to 5ffdecb Compare September 8, 2023 13:47
@literat literat force-pushed the refactor/use-visually-hidden-component branch from 5ffdecb to d19b59e Compare September 8, 2023 13:52
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Coverage Status

coverage: 69.502% (-27.0%) from 96.46% when pulling d19b59e on refactor/use-visually-hidden-component into e987ea3 on main.

@literat literat merged commit 46a120a into main Sep 8, 2023
32 checks passed
@literat literat deleted the refactor/use-visually-hidden-component branch September 8, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring A code change that neither fixes a bug nor adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants