Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(web): Prevent from removing spacing from Stack first child element #1041

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Fix(web): Prevent from removing spacing from Stack first child element #1041

merged 1 commit into from
Sep 26, 2023

Conversation

chadimaOndrej
Copy link
Contributor

@chadimaOndrej chadimaOndrej commented Sep 5, 2023 •
edited
Loading

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@netlify
Copy link

netlify bot commented Sep 5, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 6cad09c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/6512a73bee296100083ddd05
😎 Deploy Preview https://deploy-preview-1041--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the bug Something isn't working label Sep 5, 2023
@chadimaOndrej chadimaOndrej force-pushed the fix/no-remove-spacing-on-first-element-on-stack branch from 2656753 to 9ac8fa4 Compare September 5, 2023 13:41
@chadimaOndrej chadimaOndrej changed the title Fix(web): No remove spacing on first elememnt on stack with intermedi… Fix(web): No remove spacing on first element on stack with intermedi… Sep 5, 2023
@netlify
Copy link

netlify bot commented Sep 5, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit 6cad09c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/6512a73bb5fa6100083d8a5e
😎 Deploy Preview https://deploy-preview-1041--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 5, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit 6cad09c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/6512a73bb5fa6100083d8a63

@netlify
Copy link

netlify bot commented Sep 5, 2023 •
edited
Loading

✅ Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit 6cad09c
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/6512a73bfcb8fc0008c92750
😎 Deploy Preview https://deploy-preview-1041--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Coverage Status

coverage: 69.502% (-0.6%) from 70.148% when pulling 9ac8fa4 on fix/no-remove-spacing-on-first-element-on-stack into ec381f7 on main.

@chadimaOndrej chadimaOndrej changed the title Fix(web): No remove spacing on first element on stack with intermedi… Fix(web): Prevent spacing on first element on stack with intermedi… Sep 5, 2023
@chadimaOndrej chadimaOndrej force-pushed the fix/no-remove-spacing-on-first-element-on-stack branch from 9ac8fa4 to 62945cc Compare September 5, 2023 14:24
@chadimaOndrej chadimaOndrej changed the title Fix(web): Prevent spacing on first element on stack with intermedi… Fix(web): Prevent from removing spacing from Stack first child element Sep 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Coverage Status

coverage: 69.502% (-0.6%) from 70.148% when pulling 62945cc on fix/no-remove-spacing-on-first-element-on-stack into ec381f7 on main.

@dlouhak dlouhak self-requested a review September 7, 2023 09:52
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Coverage Status

coverage: 69.502% (-0.6%) from 70.148% when pulling 4db1719 on fix/no-remove-spacing-on-first-element-on-stack into ec381f7 on main.

@chadimaOndrej chadimaOndrej force-pushed the fix/no-remove-spacing-on-first-element-on-stack branch from 4db1719 to 2384128 Compare September 12, 2023 20:28
@coveralls
Copy link

coveralls commented Sep 12, 2023 •
edited
Loading

Coverage Status

coverage: 71.873% (-24.6%) from 96.46% when pulling 6cad09c on fix/no-remove-spacing-on-first-element-on-stack into f3cfd93 on main.

literat
literat approved these changes Sep 13, 2023
View reviewed changes
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am letting @adamkudrna decide if this is ok.

@adamkudrna
Copy link
Contributor

Please fix the commit message to be more 🇬🇧

Prevent Stack with inner dividers from suppressing vertical spacing of outer items

🎉

@crishpeen crishpeen force-pushed the fix/no-remove-spacing-on-first-element-on-stack branch from 2384128 to 6cad09c Compare September 26, 2023 09:41
@crishpeen crishpeen merged commit e32b945 into main Sep 26, 2023
24 checks passed
@crishpeen crishpeen deleted the fix/no-remove-spacing-on-first-element-on-stack branch September 26, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlouhak dlouhak dlouhak approved these changes

@vmilersky vmilersky vmilersky approved these changes

@crishpeen crishpeen crishpeen approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani is a code owner

Assignees

@chadimaOndrej chadimaOndrej

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chadimaOndrej @coveralls @adamkudrna @literat @crishpeen @vmilersky @dlouhak