Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web-react, web-twig) Add FileUploader demo #DS-896 #1040

Merged
merged 4 commits into from
Sep 8, 2023

Conversation

pavelklibani
Copy link
Contributor

Description

FileUploader demo in web-react is now same as demo in web and web-twig.

Additional context

Minor fixes:

  • Icon color in web-twig was not changing correctly in the disabled state (chrome browser).
    image

  • Drag&Drop in web-react was still working when the field was disabled.
    image

Issue reference

Demo: FileUploader má ve všech technologiích stejná dema

@pavelklibani pavelklibani self-assigned this Sep 5, 2023
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for spirit-design-system-demo canceled.

Name Link
🔨 Latest commit ae7ac9f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/64faed27237f240008367481

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit ae7ac9f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/64faed2764aacf00082d3177
😎 Deploy Preview https://deploy-preview-1040--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 5, 2023
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit ae7ac9f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/64faed27dd56400008d0e6cc

@pavelklibani pavelklibani force-pushed the docs/DS-896-fileuploader-demo branch from 13f94d1 to 270abf3 Compare September 5, 2023 11:11
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit ae7ac9f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/64faed27dc8ec00008ed323c
😎 Deploy Preview https://deploy-preview-1040--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Coverage Status

coverage: 69.502% (-0.6%) from 70.148% when pulling 270abf3 on docs/DS-896-fileuploader-demo into ec381f7 on main.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, move the base64 demo image to a separate file location and add the test for the utility function. Thanks.

Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pavelklibani pavelklibani force-pushed the docs/DS-896-fileuploader-demo branch from 0636833 to d7d38e0 Compare September 8, 2023 09:41
FileUploader icon now has the correct color in the disabled state
Now is not possible to drag and drop new files when the input
is disabled.
FileUploader demo in web-react is now same as demo in web and web-twig
Fixed some text in twig demo to demos are all same
@pavelklibani pavelklibani force-pushed the docs/DS-896-fileuploader-demo branch from d7d38e0 to ae7ac9f Compare September 8, 2023 09:45
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Coverage Status

coverage: 69.502% (-0.4%) from 69.879% when pulling ae7ac9f on docs/DS-896-fileuploader-demo into 28113e9 on main.

@pavelklibani pavelklibani merged commit 9b5432c into main Sep 8, 2023
@pavelklibani pavelklibani deleted the docs/DS-896-fileuploader-demo branch September 8, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants