-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs(web-react, web-twig) Add FileUploader demo #DS-896 #1040
Conversation
✅ Deploy Preview for spirit-design-system-demo canceled.
|
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-validations canceled.
|
13f94d1
to
270abf3
Compare
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, move the base64 demo image to a separate file location and add the test for the utility function. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
...t/src/components/FileUploader/demo/FileUploaderInputMultipleWithFileQueueBehaviorControl.tsx
Outdated
Show resolved
Hide resolved
0636833
to
d7d38e0
Compare
FileUploader icon now has the correct color in the disabled state
Now is not possible to drag and drop new files when the input is disabled.
FileUploader demo in web-react is now same as demo in web and web-twig
Fixed some text in twig demo to demos are all same
d7d38e0
to
ae7ac9f
Compare
Description
FileUploader demo in web-react is now same as demo in web and web-twig.
Additional context
Minor fixes:
Icon color in
web-twig
was not changing correctly in the disabled state (chrome browser).Drag&Drop in
web-react
was still working when the field was disabled.Issue reference
Demo: FileUploader má ve všech technologiích stejná dema