-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs(web-react): Introduce stories to the rest of the components #DS-476 #1037
Conversation
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
06f4a37
to
56f3d60
Compare
✅ Deploy Preview for spirit-design-system-validations canceled.
|
✅ Deploy Preview for spirit-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
It is looking good but I have started having a problem with mixing stories with component files. The original concept was to have one Do you think that will be possible to move those files into the |
Sure it could be anywhere. We just have to agree on the system. I would prefer to have everything everywhere inside the stories folder. Or have only subcomponents in the stories folder and the main one will be still in the root. |
We decided to move all stories to the stories folder. But it will be another PR. |
Affected components are Accordion, Breadcrumbs, Collapse, Dropdown, Header, Icon, Pagination, ScrollView, Spinner, Tabs and Tooltip.
cbb94bb
to
f221eaa
Compare
Issue reference
DS-476
Before submitting the PR, please make sure you do the following
fixes #123
).