Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs(web-react): Introduce stories to the rest of the components #DS-476 #1037

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

crishpeen
Copy link
Member

Issue reference

DS-476


Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Follow the PR Title/Commit Message Convention.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@crishpeen crishpeen requested a review from adamkudrna September 1, 2023 13:28
@crishpeen crishpeen self-assigned this Sep 1, 2023
@crishpeen crishpeen requested review from literat, pavelklibani and a team as code owners September 1, 2023 13:28
@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit f221eaa
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/64fe3b73bc3fc60008395d3d
😎 Deploy Preview https://deploy-preview-1037--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for spirit-design-system-demo ready!

Name Link
🔨 Latest commit f221eaa
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-demo/deploys/64fe3b737fde590008fe0f68
😎 Deploy Preview https://deploy-preview-1037--spirit-design-system-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for spirit-design-system-validations canceled.

Name Link
🔨 Latest commit f221eaa
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-validations/deploys/64fe3b737fde590008fe0f6d

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for spirit-design-system-react ready!

Name Link
🔨 Latest commit f221eaa
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-react/deploys/64fe3b73218de70008f2ed94
😎 Deploy Preview https://deploy-preview-1037--spirit-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Coverage Status

coverage: 69.502% (-0.7%) from 70.213% when pulling 56f3d60 on docs/stories-rest into 439654f on main.

@literat
Copy link
Collaborator

literat commented Sep 5, 2023

It is looking good but I have started having a problem with mixing stories with component files. The original concept was to have one .stories.tsx in the component directory which imports files from /stories directory. But now there are several stories mixed with component files and it looks a little bit messy for me and I do not quite like it. :-/

Do you think that will be possible to move those files into the stories directory when there is more than one story? Storybook only picks the .stories. extension so it does not care where the story is really placed. 🤷

@crishpeen
Copy link
Member Author

It is looking good but I have started having a problem with mixing stories with component files. The original concept was to have one .stories.tsx in the component directory which imports files from /stories directory. But now there are several stories mixed with component files and it looks a little bit messy for me and I do not quite like it. :-/

Do you think that will be possible to move those files into the stories directory when there is more than one story? Storybook only picks the .stories. extension so it does not care where the story is really placed. 🤷

Sure it could be anywhere. We just have to agree on the system. I would prefer to have everything everywhere inside the stories folder. Or have only subcomponents in the stories folder and the main one will be still in the root.

@crishpeen
Copy link
Member Author

It is looking good but I have started having a problem with mixing stories with component files. The original concept was to have one .stories.tsx in the component directory which imports files from /stories directory. But now there are several stories mixed with component files and it looks a little bit messy for me and I do not quite like it. :-/
Do you think that will be possible to move those files into the stories directory when there is more than one story? Storybook only picks the .stories. extension so it does not care where the story is really placed. 🤷

Sure it could be anywhere. We just have to agree on the system. I would prefer to have everything everywhere inside the stories folder. Or have only subcomponents in the stories folder and the main one will be still in the root.

We decided to move all stories to the stories folder. But it will be another PR.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

Coverage Status

coverage: 69.502% (-0.7%) from 70.213% when pulling cbb94bb on docs/stories-rest into 439654f on main.

Affected components are Accordion, Breadcrumbs, Collapse, Dropdown, Header,
Icon, Pagination, ScrollView, Spinner, Tabs and Tooltip.
@coveralls
Copy link

coveralls commented Sep 10, 2023

Coverage Status

coverage: 70.438%. remained the same when pulling f221eaa on docs/stories-rest into 7f05e3e on main.

@crishpeen crishpeen merged commit 8b0255f into main Sep 10, 2023
28 checks passed
@crishpeen crishpeen deleted the docs/stories-rest branch September 10, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants