Chore(repo): Migration to Yarn Modern #1029

literat · 2023-08-30T13:08:20Z

Description

Yarn v1 is an old implementation and has been recommended to migrate to modern versions. Today's version is v4 (https://yarnpkg.com/blog/release/4.0) - we cannot go to v4 since it requires Node.js v18.
We are migrating to the latest v3 (https://v3.yarnpkg.com/) which is far more performant and has better verbose messages.

There are a few changes like the configuration going through the yarnrc.yml or that the pre and post hooks do not work (due to possible collisions in the script lifecycle).

Please, give this everyone a try. I need to know that everything is working for you. And finally we will be a little more up-to-date :-)

Additional context

@see: https://yarnpkg.com/getting-started/install

There were some additional modifications that need to be done:

adding missing dependencies
fixing Stylelint errors - @adamkudrna and @crishpeen please, have a look
fixing build scripts

The changes are in separate commits to allow better fixing.

Issue reference

refs #264

Before submitting the PR, please make sure you do the following

Read the Contributing Guidelines.
Follow the PR Title/Commit Message Convention.
Provide a description in this PR that addresses what the PR is solving, or reference the issue it solves (e.g. fixes #123).
Ideally, include relevant tests that fail without this PR but pass with it.

netlify · 2023-08-30T13:19:31Z

✅ Deploy Preview for spirit-design-system-storybook ready!

Name	Link
🔨 Latest commit	`7e5e179`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66263afc59242f00081164ef
😎 Deploy Preview	https://deploy-preview-1029--spirit-design-system-storybook.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-08-30T13:21:45Z

✅ Deploy Preview for spirit-design-system-demo canceled.

Name	Link
🔨 Latest commit	`6ee9d3e`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-demo/deploys/65fb00f89703110008d9be86

netlify · 2023-08-30T13:24:11Z

✅ Deploy Preview for spirit-design-system-validations canceled.

Name	Link
🔨 Latest commit	`7e5e179`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system-validations/deploys/66263afc4594e4000828cfbf

coveralls · 2024-01-11T16:00:46Z

coverage: 80.657%. remained the same
when pulling 7e5e179 on chore/migrade-to-yarn-modern
into 7a35154 on main.

literat · 2024-02-15T19:12:04Z

jupyter-lsp/jupyterlab-lsp#1021

literat · 2024-02-15T19:12:12Z

https://yarnpkg.com/features/linkers

package.json

.yarnrc.yml

.stylelintrc.js

.gitignore

packages/analytics/package.json

packages/web-react/config/vite/app.ts

packages/web-react/src/components/Accordion/demo/index.tsx

packages/web-react/src/components/Collapse/demo/index.tsx

netlify · 2024-04-05T18:54:22Z

✅ Deploy Preview for spirit-design-system ready!

Name	Link
🔨 Latest commit	`7e5e179`
🔍 Latest deploy log	https://app.netlify.com/sites/spirit-design-system/deploys/66263afc321f3a00087f408e
😎 Deploy Preview	https://deploy-preview-1029--spirit-design-system.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 96 (no change from production) Accessibility: 93 (no change from production) Best Practices: 100 (no change from production) SEO: 82 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

packages/web/package.json

packages/web-react/src/components/Collapse/demo/index.tsx

packages/web-react/package.json

packages/design-tokens/src/scss/generated/_gradients.scss

.stylelintrc.js

.yarnrc.yml

.stylelintrc.js

package.json

literat · 2024-04-18T19:51:27Z

@adamkudrna @crishpeen From my point of view this is read-to-go. Let's discuss the documentation of getting started with Yarn, but I think this is covered by prerequisites in the main README. Please, be short.

.yarn/releases/yarn-3.6.3.cjs

exporters/scss/package.json

crishpeen

So I tested it and it works.

I just pulled the branch, make install, make build and make start and no problems. I didn't have to do anything more, that's great.

So please just fix those two points I wrote earlier today and it is good to go for me.

Good job!

.yarnrc.yml

adamkudrna

Thank you for cleaning up the task names! 👏🏻

.yarnrc.yml

@see

* @see: https://yarnpkg.com/getting-started/install refs #264

@see

* @see: https://yarnpkg.com/getting-started/install refs #264

@see

* @see https://yarnpkg.com/advanced/lifecycle-scripts

* first parent id given is `undefined` because it is a starting point * use `resolve` plugin to find directory indexes (index.js) * set `preventAssignment` to true because it will be the default in the next Rollup release

* `normalizeColor` can now produce both short and long hex colors base on the flag

* fixed supported node version

* `normalizeColor` can now produce both short and long hex colors base on the flag

github-actions bot assigned literat Aug 30, 2023

github-actions bot added the maintenance Changes to the build process or auxilary tools and libraries or other maintenance label Aug 30, 2023

pavelklibani approved these changes Sep 26, 2023

View reviewed changes

literat force-pushed the chore/migrade-to-yarn-modern branch from 839638d to 446e189 Compare November 14, 2023 14:44

literat force-pushed the chore/migrade-to-yarn-modern branch from 446e189 to 77de4da Compare December 18, 2023 16:08

literat force-pushed the chore/migrade-to-yarn-modern branch 2 times, most recently from 3d14103 to 8c3bd7e Compare January 11, 2024 14:39

literat force-pushed the chore/migrade-to-yarn-modern branch 2 times, most recently from 2290b1b to fadbcb1 Compare January 24, 2024 10:50

literat marked this pull request as ready for review January 24, 2024 11:04

literat requested review from a team, adamkudrna and crishpeen as code owners January 24, 2024 11:04

literat requested a review from pavelklibani January 24, 2024 11:07

literat force-pushed the chore/migrade-to-yarn-modern branch 3 times, most recently from ac62d0f to 2f02196 Compare February 20, 2024 15:44

adamkudrna reviewed Feb 20, 2024

View reviewed changes

literat force-pushed the chore/migrade-to-yarn-modern branch from 5f0fd0f to 6ee9d3e Compare March 20, 2024 15:29

literat force-pushed the chore/migrade-to-yarn-modern branch from 6ee9d3e to 34cc809 Compare April 5, 2024 18:54

literat force-pushed the chore/migrade-to-yarn-modern branch 2 times, most recently from 1ce0b33 to 3b9782d Compare April 8, 2024 08:10

crishpeen requested changes Apr 9, 2024

View reviewed changes

literat force-pushed the chore/migrade-to-yarn-modern branch 2 times, most recently from a1da524 to b91b19f Compare April 18, 2024 13:07

literat requested review from crishpeen and adamkudrna April 18, 2024 19:32

literat force-pushed the chore/migrade-to-yarn-modern branch 2 times, most recently from 021ebac to 183f7be Compare April 18, 2024 19:48

crishpeen reviewed Apr 19, 2024

View reviewed changes

.yarn/releases/yarn-3.6.3.cjs Outdated Show resolved Hide resolved

exporters/scss/package.json Outdated Show resolved Hide resolved

crishpeen approved these changes Apr 19, 2024

View reviewed changes

.yarnrc.yml Show resolved Hide resolved

literat force-pushed the chore/migrade-to-yarn-modern branch 2 times, most recently from 38bca97 to 56a65f0 Compare April 19, 2024 12:36

lmc-eu deleted a comment from netlify bot Apr 19, 2024

adamkudrna approved these changes Apr 22, 2024

View reviewed changes

.yarnrc.yml Show resolved Hide resolved

literat added 14 commits April 22, 2024 12:24

Chore(repo): Migrate to Yarn Modern

12e3b72

* @see: https://yarnpkg.com/getting-started/install refs #264

Style(design-tokens): Fix color hex length to short

f41dd12

Style(web-react): Ignore unresolved file when icons are not built

a87e03b

Chore(repo): Migrate to Yarn Modern

3715b7d

* @see: https://yarnpkg.com/getting-started/install refs #264

Refactor(ci): Yarn no longer supports pre* and post* scripts

7ee0c67

* @see https://yarnpkg.com/advanced/lifecycle-scripts

Chore(web-react): Fix non resolvable modules and types

d6ae83a

Chore(web-react): Resolve paths to icons using alias

03710d1

Chore(repo): Add missing jest dependency

1a03929

Chore(exporter-scss): Add missing package dependencies

7d81028

Feat(exporter-scss): Normalize color string to short hex

4a16ce9

* `normalizeColor` can now produce both short and long hex colors base on the flag

Chore(exporter-js): Add missing dependencies

286578c

Chore(repo): Enable Yarn to check engines by adding plugin

58c8a4b

* fixed supported node version

Feat(exporter-js): Normalize color string to short hex

7e5e179

* `normalizeColor` can now produce both short and long hex colors base on the flag

literat force-pushed the chore/migrade-to-yarn-modern branch from 56a65f0 to 7e5e179 Compare April 22, 2024 10:24

literat merged commit 4702a3d into main Apr 22, 2024
35 checks passed

literat deleted the chore/migrade-to-yarn-modern branch April 22, 2024 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore(repo): Migration to Yarn Modern #1029

Chore(repo): Migration to Yarn Modern #1029

literat commented Aug 30, 2023 •

edited

Loading

netlify bot commented Aug 30, 2023 •

edited

Loading

netlify bot commented Aug 30, 2023 •

edited

Loading

netlify bot commented Aug 30, 2023 •

edited

Loading

coveralls commented Jan 11, 2024 •

edited

Loading

literat commented Feb 15, 2024

literat commented Feb 15, 2024

netlify bot commented Apr 5, 2024 •

edited

Loading

literat commented Apr 18, 2024

crishpeen left a comment

adamkudrna left a comment

Chore(repo): Migration to Yarn Modern #1029

Chore(repo): Migration to Yarn Modern #1029

Conversation

literat commented Aug 30, 2023 • edited Loading

Description

Additional context

Issue reference

Before submitting the PR, please make sure you do the following

netlify bot commented Aug 30, 2023 • edited Loading

✅ Deploy Preview for spirit-design-system-storybook ready!

netlify bot commented Aug 30, 2023 • edited Loading

✅ Deploy Preview for spirit-design-system-demo canceled.

netlify bot commented Aug 30, 2023 • edited Loading

✅ Deploy Preview for spirit-design-system-validations canceled.

coveralls commented Jan 11, 2024 • edited Loading

literat commented Feb 15, 2024

literat commented Feb 15, 2024

netlify bot commented Apr 5, 2024 • edited Loading

✅ Deploy Preview for spirit-design-system ready!

literat commented Apr 18, 2024

crishpeen left a comment

Choose a reason for hiding this comment

adamkudrna left a comment

Choose a reason for hiding this comment

literat commented Aug 30, 2023 •

edited

Loading

netlify bot commented Aug 30, 2023 •

edited

Loading

netlify bot commented Aug 30, 2023 •

edited

Loading

netlify bot commented Aug 30, 2023 •

edited

Loading

coveralls commented Jan 11, 2024 •

edited

Loading

netlify bot commented Apr 5, 2024 •

edited

Loading