fixup! fixup! Refactor(web): Refactor placement transformation to all…

…ow input of logical placements
lmc-eu · May 9, 2024 · 8fb1231 · 8fb1231
1 parent b17b024
commit 8fb1231
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/packages/web/src/scss/tools/__tests__/_placement.test.scss b/packages/web/src/scss/tools/__tests__/_placement.test.scss
@@ -32,8 +32,8 @@
     @include true.it('should return correct physical placement') {
         @include true.assert {
             @include true.output {
-                --logical-to-physical-start-horizontal: #{placement.logical-to-physical('start', 'horizontal')};
-                --logical-to-physical-start-vertical: #{placement.logical-to-physical('start', 'vertical')};
+                --logical-to-physical-start-horizontal: #{placement.transform-logical-to-physical('start', 'horizontal')};
+                --logical-to-physical-start-vertical: #{placement.transform-logical-to-physical('start', 'vertical')};
             }
             @include true.expect {
                 --logical-to-physical-start-horizontal: left;

diff --git a/packages/web/src/scss/tools/_placement.scss b/packages/web/src/scss/tools/_placement.scss
@@ -135,8 +135,8 @@ $_hyphen: '-';
 }
 
 // Function to return a physical placement name
-// Example: logical-to-physical('start', $direction: 'horizontal') will return 'left'
-@function logical-to-physical($logical, $direction) {
+// Example: transform-logical-to-physical('start', $direction: 'horizontal') will return 'left'
+@function transform-logical-to-physical($logical, $direction) {
     @return map.get($_logical-to-physical-placement-map, $direction, $logical);
 }
 
@@ -154,7 +154,7 @@ $_hyphen: '-';
         }
 
         @if $physical-direction {
-            $axis-transformed: logical-to-physical($axis-transformed, $physical-direction);
+            $axis-transformed: transform-logical-to-physical($axis-transformed, $physical-direction);
         }
     } @else if $inverse {
         $axis-transformed: map.get($_physical-placement-inverse-map, $axis);