Skip to content

Commit

Permalink
fixup! Docs(repo): Introduce postmortem to excessive Icon logging
Browse files Browse the repository at this point in the history
  • Loading branch information
literat committed Feb 13, 2024
1 parent 41b5dbd commit 3d96018
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions docs/postmortems/2024-02-05-deprecated-icon-rendering.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,14 @@ issues and Pull Requests in the "Bug" column with the appropriate owners -->

**What went well**

- We have dealed with this problem multiple times so we have a good idea what is causing the problem.
- We have dealt with this problem multiple times so we have a good idea what is causing the problem.
- The product teams were able to quickly identify the problem and raise the question in the Slack channel.

**What went wrong**

- The lack of testing of the integration of the `html-react-parser` as dynamically imported dependency and the `Icon` component.
- A little awerness of how extensively is the `Icon` component used in our components and the product components.
- A little awareness of how extensively is the `Icon` component used in our components and the product components.
- We were adding multiple dependencies as peer dependencies and thought that the developers will deal with the installing. Instead the regular dependency should be added. The regular dependency is not a part of the bundle unless we set it. We were trying to use as less dependencies as possible, however in this case it was not the best approach. We care a lot about the bundle/package size.

**Where we got lucky**

Expand All @@ -93,7 +94,7 @@ issues and Pull Requests in the "Bug" column with the appropriate owners -->
2024-02-06

- 12:24 @pavelklibani started to work on the support question
- 13:08 The new issue was added by @literat to the ticketing system - https://jira.almacareer.tech/browse/DS-1145
- 13:08 The new issue was added by @literat to the ticketing system - [DS-1145](https://jira.almacareer.tech/browse/DS-1145)
- 15:56 @literat came with the first version of the solution

2024-02-07
Expand All @@ -108,5 +109,5 @@ issues and Pull Requests in the "Bug" column with the appropriate owners -->
<!-- Any additional information that you might reference earlier on in the
postmortem -->

Commit introducing the problematic deprecation warning: https://github.com/lmc-eu/spirit-design-system/commit/79f9f6f207c87296c0c5af1d6c521f48f73206eb
PR containing the problematic deprecation warning: https://github.com/lmc-eu/spirit-design-system/pull/1200
Commit introducing the problematic deprecation warning: [79f9f6f](https://github.com/lmc-eu/spirit-design-system/commit/79f9f6f207c87296c0c5af1d6c521f48f73206eb)
PR containing the problematic deprecation warning: [#1200](https://github.com/lmc-eu/spirit-design-system/pull/1200)

0 comments on commit 3d96018

Please sign in to comment.