[Coroutines] Fix warnings

This patch fixes: llvm/include/llvm/Transforms/Coroutines/CoroSplit.h:26:1: note: did you mean struct here? llvm/lib/Transforms/Coroutines/CoroSplit.cpp:2225:16: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move] llvm/lib/Transforms/Coroutines/CoroSplit.cpp:2236:16: error: moving a local object in a return statement prevents copy elision [-Werror,-Wpessimizing-move]
llvm · Oct 3, 2024 · 313ad85 · 313ad85 · TylerNowicki · Oct 3, 2024
1 parent d412cea
commit 313ad85
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/llvm/include/llvm/Transforms/Coroutines/CoroSplit.h b/llvm/include/llvm/Transforms/Coroutines/CoroSplit.h
@@ -23,7 +23,7 @@ namespace llvm {
 
 namespace coro {
 class BaseABI;
-class Shape;
+struct Shape;
 } // namespace coro
 
 struct CoroSplitPass : PassInfoMixin<CoroSplitPass> {

diff --git a/llvm/lib/Transforms/Coroutines/CoroSplit.cpp b/llvm/lib/Transforms/Coroutines/CoroSplit.cpp
@@ -2222,7 +2222,7 @@ CoroSplitPass::CoroSplitPass(bool OptimizeFrame)
         std::unique_ptr<coro::BaseABI> ABI =
             CreateNewABI(F, S, coro::isTriviallyMaterializable);
         ABI->init();
-        return std::move(ABI);
+        return ABI;
       }),
       OptimizeFrame(OptimizeFrame) {}
 
@@ -2233,7 +2233,7 @@ CoroSplitPass::CoroSplitPass(std::function<bool(Instruction &)> IsMatCallback,
     : CreateAndInitABI([=](Function &F, coro::Shape &S) {
         std::unique_ptr<coro::BaseABI> ABI = CreateNewABI(F, S, IsMatCallback);
         ABI->init();
-        return std::move(ABI);
+        return ABI;
       }),
       OptimizeFrame(OptimizeFrame) {}