[CIR][CIRGen][Builtin] Support __builtin_launder except in the case of -fstrict-vtable-pointers #1138
+338
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
approved these changes
Nov 22, 2024
| @@ -230,6 +230,7 @@ struct MissingFeatures { | |||
| static bool emitEmptyRecordCheck() { return false; } | |||
| static bool isPPC_FP128Ty() { return false; } | |||
| static bool emitBinaryAtomicPostHasInvert() { return false; } | |||
| static bool createLaunderInvariantGroup() { return false; } | |||
There was a problem hiding this comment.
We already have createInvariantGroup, should we use that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without using flag
-fstrict-vtable-pointers,__builtin_launderis a noop. This PR implements that, and leave implementation for the case of-fstrict-vtable-pointersto future where there is a need.This PR also adapted most of test cases from OG test case.
I didn't use test cases in the namespace pessimizing_cases, as they have no difference even when
-fstrict-vtable-pointersis on.