Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common-java:DuplicatedBlocks - Source files should not have any duplicated blocks #80

Merged
merged 1 commit into from
May 4, 2016
Merged

common-java:DuplicatedBlocks - Source files should not have any duplicated blocks #80

merged 1 commit into from
May 4, 2016

Conversation

georgekankava
Copy link
Contributor

This pull request is focused on resolving occurrences of Sonar rule
common-java:DuplicatedBlocks - Source files should not have any duplicated blocks.
You can find more information about the issue here:
https://dev.eclipse.org/sonar/rules/show/common-java:DuplicatedBlocks
Please let me know if you have any questions.
George Kankava

@Skylion007 Skylion007 merged commit d68aa45 into lkuza2:master May 4, 2016
@Skylion007
Copy link
Collaborator

Thx again for the code cleaning. :)

@georgekankava
Copy link
Contributor Author

@Skylion007 It has a little problem with maven-javadoc-plugin while mvn clean package. Seems it doesn't like new addition. I don't have much experience with that plugin. Hope you will handle that easier or if not please let me know and I will take a look later.

@Skylion007
Copy link
Collaborator

Skylion007 commented May 4, 2016

Ah you mean the previous maven addition? I don't see any changes to maven in the pull request? Unfortunately, I don't have a terrible amount of experience with maven either.

@Skylion007
Copy link
Collaborator

Skylion007 commented May 4, 2016

Ah so this isn't an issue with Maven at all. Javadocs will just crash with malformed Javadocs. If we fix the JavaDoc lines its complaining about, Maven should work just fine.To fix this we just need to add a string after the errors it is throwing. For instance, @throws LineUnavailableException must have a string following it explaning why it throws that. Simply having @param paramname is insufficient. I'll open an issue to track this.

@Skylion007
Copy link
Collaborator

Moving this issue to #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants