fix(web): fixes from code review

lkocman · Sep 5, 2024 · 18b48cc · 18b48cc
1 parent ed0025a
commit 18b48cc
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 13 deletions.
diff --git a/service/lib/agama/software/product.rb b/service/lib/agama/software/product.rb
@@ -49,7 +49,7 @@ class Product
       attr_accessor :version
 
       # Product icon. Please use specify filename with svg suffix and ensure referenced
-      # file exists inside agama/web/src/assests/product.
+      # file exists inside agama/web/src/assets/product.
       # `default.svg` will be used unless specified otherwise.
       #
       # @return [String] E.g. "leap.svg"

diff --git a/service/package/rubygem-agama-yast.changes b/service/package/rubygem-agama-yast.changes
@@ -1,3 +1,8 @@
+-------------------------------------------------------------------
+Thu Sep  5 16:25:00 UTC 2024 - Lubos Kocman <[email protected]>
+
+- Show product logo in product selector (gh#openSUSE/agama#1415).
+
 -------------------------------------------------------------------
 Wed Sep  4 08:55:29 UTC 2024 - José Iván López González <[email protected]>
 
@@ -27,12 +32,6 @@ Mon Aug 26 10:01:27 UTC 2024 - Imobach Gonzalez Sosa <[email protected]>
 - Do not depend on f2fs-tools and nilfs-utils
   (jsc#PED-8669, gh#openSUSE/agama#1554).
 
--------------------------------------------------------------------
-Wed Aug 21 19:07:28 UTC 2024 - Lubos Kocman <[email protected]>
-
-- Add product icons. Resolves Issue #1415
-  Not setting any icon will default to default.svg icon
-
 -------------------------------------------------------------------
 Mon Aug 19 15:13:46 UTC 2024 - Lubos Kocman <[email protected]>
 

diff --git a/web/src/components/core/ChangeProductLink.test.tsx b/web/src/components/core/ChangeProductLink.test.tsx
@@ -26,17 +26,17 @@ import { PATHS } from "~/routes/products";
 import { Product } from "~/types/software";
 import ChangeProductLink from "./ChangeProductLink";
 
-const tumbleweedProduct = {
+const tumbleweed: Product = {
   id: "Tumbleweed",
   name: "openSUSE Tumbleweed",
+  icon: "tumbleweed.svg",
   description: "Tumbleweed description...",
-  icon: "Tumbleweed.icon",
 };
-const microosProduct = {
+const microos: Product = {
   id: "MicroOS",
   name: "openSUSE MicroOS",
+  icon: "MicroOS.svg",
   description: "MicroOS description",
-  icon: "MicroOS.icon",
 };
 
 let mockUseProduct: { products: Product[]; selectedProduct?: Product };
@@ -48,7 +48,7 @@ jest.mock("~/queries/software", () => ({
 describe("ChangeProductLink", () => {
   describe("when there is more than one product available", () => {
     beforeEach(() => {
-      mockUseProduct = { products: [tumbleweedProduct, microosProduct] };
+      mockUseProduct = { products: [tumbleweed, microos] };
     });
 
     it("renders a link for navigating to product selection page", () => {
@@ -60,7 +60,7 @@ describe("ChangeProductLink", () => {
 
   describe("when there is only one product available", () => {
     beforeEach(() => {
-      mockUseProduct = { products: [tumbleweedProduct] };
+      mockUseProduct = { products: [tumbleweed] };
     });
 
     it("renders nothing", () => {