Bots logging on/off

[tugofpeas]

Describe the bug
Account bots, who are on friends' list will log on and immediately off about every 15 seconds.

Commit hash
I'm currently on d9f9d98 but also observed it in eef41ab.

To Reproduce
Steps to reproduce the behavior:

1. Create an account character, enter the world. Log off.
2. Get on another character, add the other char to friends
3. Your chat window will start spamming that [Character] came online/ went offline with the frequency of about 15-20 seconds.

Expected behavior
Chars shouldn't be coming online randomly.

Screenshots

Desktop (please complete the following information):
Windows 11, World of Warcraft 3.3.5a.12340 enUS client
AC Server - Debian 12

Additional context

[Dreathean]

I'm not experiencing this and I'm updated up until maybe the last 1-2 PRs, what other modules are you running?

[tugofpeas]

The only mods I have are:
mod_ah_bot
mod_playerbots

[kaijikan]

1. Create an account character, enter the world. Log off.
2. Get on another character, add the other char to friends
3. Your chat window will start spamming that [Character] came online/ went offline with the frequency of about 15-20 seconds.

Expected behavior Chars shouldn't be coming online randomly.

I had a similar issue to this, and fixed it by wiping and regenerating the bots, which did by editing the playerbots.conf file

.../azerothcore/env/dist/etc/modules/playerbots.conf

Enable the Delete bots setting, and restart your server.
AiPlayerbot.DeleteRandomBotAccounts = 1

Once you server has completed loading, disable the setting once more, and restart your server
AiPlayerbot.DeleteRandomBotAccounts = 0

Now all the bots should re-generate, and you will not get them logging in and out en-mass

Hope this works for you too

[tugofpeas]

@kaijikan Thanks, I'll try that.
In my case, this issue only occurs when I set AiPlayerbot.RandomBotAccountCount above 200 and the min and max bots are equal or more than 200. Feels like some sort of rounding issue or something. For example, when all 3 settings are at 300, the # of bots online will be 297, instead of 300. And the remaining 3 bots will keep on triggering the logging on/off endlessly.

[icemansparks]

I had the same behavior with friends/guild characters after adding the mod to an existing server with player characters that were present before the mod installation.

This resulted in player characters being associated with bot accounts. Regenerating doesn't fix this issue for me.

I have a detailed description in #449 (currently working on a fix) - maybe this is something similar?