Add Fields to Fetch and Add Content to BookItemBack #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@om9090 is attempting to deploy a commit to the livoszlak's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move title and author/-s to BookItem - but please make sure both will fit above or beneath cover image, in a way that doesn't mess with the styling cohesion. Title and author/-s should have the same space on every BookItem card, and cover image should also maintain consistent space on the card. In v1 of this project, I solved the issue of different lengths of titles and author names with having them "disappear" under ellipses, but perhaps you have a better solution?
Having moved title and author from the back view of the card, display Page count and categories there instead. And perhaps description can appear in an additional BookItemBack component if user clicks a "See description"-button? Check out Nested modal - is it possible to have the child modal appear next to the parent modal? Side by side, sliding in from right? Let's find out!
If "See description" child modal is implemented, perhaps replace the link icon on the back view of the parent modal with a "View on Google Books" button?
[
](
url)