Move model parser to separate class #74
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to make some structural changes to the library. As explained in #72 I want to simplify the configuration. But next to this I also want to separate the business logic (the parsing) from the domain objects (the Model).
My proposal therefore is to have separate parsing classes (like the
ModelParser
in the commit) and separate domain objects (Model
). This way we can separate the different concerns:Let me know if you like this direction, then I could extend this to all domain objects and start separating the steps.