Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move model parser to separate class #74

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StefSchenkelaars
Copy link

I wanted to make some structural changes to the library. As explained in #72 I want to simplify the configuration. But next to this I also want to separate the business logic (the parsing) from the domain objects (the Model).

My proposal therefore is to have separate parsing classes (like the ModelParser in the commit) and separate domain objects (Model). This way we can separate the different concerns:

  • Read the files and comments (YARD)
  • Transform the YARD objects and tags into domain objects (Parsing)
  • Transform the domain object in Swagger / OpenAPI objects (Transforming)

Let me know if you like this direction, then I could extend this to all domain objects and start separating the steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant