Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove configuration layer #72

Open
StefSchenkelaars opened this issue Nov 2, 2021 · 0 comments
Open

Remove configuration layer #72

StefSchenkelaars opened this issue Nov 2, 2021 · 0 comments

Comments

@StefSchenkelaars
Copy link

We have an application with multiple API definitions in the same codebase. Therefore we would like to be able to generate multiple specifications with different settings. This is doable but I think this flow could be improved by removing the configuration or specification layer. Let me explain.

Currently the library uses global settings which are defined in the Configuration class. Then some local configuration can be passed to the Specification class but not everything can be overwritten. Next to this, the parsing is depending on the configuration settings which makes the dependency tree quite complex.

My proposal is therefore to make merge the Configuration and Specification class. This object then defines all the settings needed throughout the modules. The Swagger and OpenAPI classes should then receive an instance of this class as an argument which completely defines all parsing and processing settings.

@nicksieger Do you think it's worth it to spend the time on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant