[VID-482] Continous record tester - decrese max fails from 5 to 3 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwilczynskiclearcode
force-pushed
the
VID-482
branch
from
264e420 to
2d8fc47
Compare
pwilczynskiclearcode
force-pushed
the
VID-482
branch
from
2d8fc47 to
ddbab5d
Compare
thomshutt
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce number of retries from 5 to 3 so we don't let repeating issues skip our monitoring.
I'd generally suggest to rewrite record-tester so it publishes prometheus metrics instead of PagerDuty alerts.
Alerts would be based on grafana metrics.
Retrials could produce a metric that would be observed… or record-tester would fail immediately and retry entire test.
Then alerts could be configured to allow short, single failures of record-tester but repeating ones would raise an actual PagerDuty alert.
This is just a thought, it's not in the scope of this PR/task.